-
Notifications
You must be signed in to change notification settings - Fork 55
fix[next]: Reduce type ignores in client code #2484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
906254f
explicitly import `fbuiltin` members in `gt4py.next`
DropD 28fdaa2
fix typos in gtx, add failing external typing tests
DropD 8681dec
fix typo in external typing CI
DropD 3964075
Merge branch 'main' into explicit-fbuiltins-imports
DropD 9854f2b
fix 'name-defined' mypy error for fbuiltins imported through gt4py.next
DropD 7b1ed38
Merge branch 'main' into explicit-fbuiltins-imports
DropD e0e6c9f
fix 'arg-type' and 'call-overload' errors from using 'field_operator'
DropD 02bc14d
add plugin to effectively ignore field dimension types
DropD ef038b8
Merge branch 'main' into explicit-fbuiltins-imports
DropD bcb960e
roll back experimental changes
DropD d7bb4a8
add more tests, partially fix 'where' type hints
DropD d56ce33
cleanup
DropD e9fdf85
fix type hints for program and scan_operator
DropD a0db128
add field ops and defer numeric precision type checking to dsl
DropD 4c252e8
Merge branch 'main' into explicit-fbuiltins-imports
DropD da6aaf0
help mypy infer `astype` return type
DropD b9cce17
add a "default-tag" config for versioningit to get rid of NoTagError
DropD 383a8e8
fix default-tag
DropD fa995be
make default tag conform to the vX.Y.Z convention
DropD 564f98c
make external typing nox session call pytest with -sv
DropD 3f55492
Merge branch 'main' into explicit-fbuiltins-imports
DropD d48e307
fix default tag interfering with installability
DropD 415a435
edit default tag to indicate dev version (only used in shallow clones)
DropD c9ac562
Fix versioningit complaints
egparedes 71ab1e1
Merge branch 'main' into explicit-fbuiltins-imports
DropD fc84bb0
replace Callable -> FunctionType casts with assert isinstance
DropD ed42283
added typing precision for field comparison ops
DropD 82d25be
Merge branch 'build/fix-versioningit-complaints' into explicit-fbuilt…
DropD 4e2a08e
experiment with default tag again
DropD e29bff0
get rid of local version info in default tag for now
DropD b9a2fde
static __all__ in fbuiltins, direct assert replaces test module
DropD 5428507
remove need for attr-defined ignores for fbuiltins members
DropD 725f3cc
experiment with removing extraneous local version info
DropD 7399d4e
revert failed experiment
DropD fc0911f
rename "external typing" -> "typing exports"
DropD 456bf81
use actual (non-any) dimension types while type checking
DropD abb72ca
[wip] fix dimension types
DropD 17d5eef
Fix local version part
egparedes a529bbc
Merge branch 'main' into build/fix-versioningit-complaints
egparedes 34ed14a
Update to current version
egparedes 1180628
Fix unit test
egparedes 043c2be
Fallback to a different strategy wrapping the versioningit calls to a…
egparedes 5216972
mypy plugin: stop blocking variadic 'Dims' types
DropD 264fef6
mypy plugin: give up on Dim types in case of error
DropD bf2f7aa
Merge branch 'build/fix-versioningit-complaints' into explicit-fbuilt…
DropD 065ea19
mypy plugin: add a clarifying comment
DropD cec6dcc
Merge branch 'main' into explicit-fbuiltins-imports
egparedes 239ac13
document mypy plugin, test gt4py.next exporting all public fbuiltins
DropD 2e1422e
upgrade CI actions
DropD 9889ed0
improve type hints and mypy plugin
DropD da20631
test for missing builtin functions in fbuiltins
DropD e527c29
fix typo in one of the typing export tests
DropD b3b2eac
Merge branch 'main' into explicit-fbuiltins-imports
DropD File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.