-
Notifications
You must be signed in to change notification settings - Fork 55
feat[next][dace]: Lowering of concat_where to SDFG #2137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 250 commits
Commits
Show all changes
316 commits
Select commit
Hold shift + click to select a range
45f8b09
Add concat_where transforms to field view transforms
tehrengruber b3647bf
Fix typo
tehrengruber 6ea11e5
Add support for tuples
tehrengruber 60d0d9a
Fixes
tehrengruber 93a6d33
Merge remote-tracking branch 'origin/main' into GTIR_concat_where
tehrengruber 132e576
Improve docs
tehrengruber e469075
Improve docs
tehrengruber d80c78d
Merge remote-tracking branch 'SF-N/GTIR_concat_where' into gtir-dace-…
edopao 24e2f57
Fix typo
tehrengruber 44036b8
make simple tests work
edopao 01e8390
Merge remote-tracking branch 'SF-N/GTIR_concat_where' into gtir-dace-…
edopao d14fb21
Cleanup & improve test coverage
tehrengruber 1e3ced5
Cleanup
tehrengruber 545ec6c
concat_where_non_overlapping passes
edopao 4fd741b
Merge remote-tracking branch 'SF-N/GTIR_concat_where' into gtir-dace-…
edopao e7ea3ce
minor edit
edopao 595b675
Cleanup
tehrengruber fac7de0
Merge remote-tracking branch 'SF-N/GTIR_concat_where' into gtir-dace-…
edopao ba40dd6
d=skip concat_where broadcast test cases
edopao 0b186d3
fix test with horizontal slice
edopao c242fb5
Revert "d=skip concat_where broadcast test cases"
edopao 6c17104
concat_where with implicit broadcast
edopao fd44ffb
fix for negative size of temporary fields
edopao 425e2f0
use domain info from node annex
edopao 945908d
preserve domain information in ReplaceSymbols IR pass
edopao 6b9dc5c
fix boundaries of field domain
edopao 59a1226
Improve type inference for concat_where tuple case
tehrengruber f832a19
Fix typo
tehrengruber 6f34d40
Merge remote-tracking branch 'SF-N/GTIR_concat_where' into gtir-dace-…
edopao 475bce2
update stride for slice argument
edopao 7b815f9
renaming of variables
edopao 51a0fd2
more renaming
edopao 75cc4f2
Fix bug in infer domain ops
tehrengruber 6e85bd0
Address review comments
tehrengruber a8b9736
Merge remote-tracking branch 'origin_tehrengruber/store_lambda_param_…
tehrengruber 9978a43
Address review comments
tehrengruber 232d4b8
Address review comments
tehrengruber 57abfaf
Merge remote-tracking branch 'origin/main' into store_lambda_param_type
tehrengruber 596debf
Merge remote-tracking branch 'SF-N/GTIR_concat_where' into gtir-dace-…
edopao 682aef4
Merge remote-tracking branch 'origin/main' into gtir-dace-concat_where
edopao 2cf3c97
edit code comments
edopao f488b1a
Merge remote-tracking branch 'origin/main' into GTIR_concat_where
tehrengruber 55dc611
Merge branch 'store_lambda_param_type' into GTIR_concat_where
tehrengruber 2674f11
Merge origin/main
tehrengruber c645cf5
Merge remote-tracking branch 'SF-N/GTIR_concat_where' into gtir-dace-…
edopao d0f93be
Fix deferred type in concat_where
tehrengruber cd248aa
Merge remote-tracking branch 'SF-N/GTIR_concat_where' into gtir-dace-…
edopao cf50a37
Fix tuple concat_where (not fully done yet)
tehrengruber 4c29e73
Merge remote-tracking branch 'SF-N/GTIR_concat_where' into gtir-dace-…
edopao 9659fba
handle scalar argument in concat_where
edopao 5fc42ce
Fix tuple concat_where (not fully done yet)
tehrengruber ec6a507
Merge remote-tracking branch 'SF-N/GTIR_concat_where' into gtir-dace-…
edopao e3b4f20
handle domain of tuples
edopao fa82974
fix source subset in concat_where memlet
edopao 321a204
cleanup
edopao 6cfc7eb
Merge remote-tracking branch 'origin/main' into gtir-dace-concat_where
edopao f0657df
change broadcast
edopao 6f23bc6
fix previous commit
edopao d63aea9
rename map range variables
edopao 3f58894
try - fix segfault by turning 1:1 into 0:0
edopao d4d301b
fix formatting
edopao 6eddf30
pruning of empty branches
edopao 674391c
fix for isolated nodes
edopao 7d328ae
undo extra change
edopao ae495cb
add test case
edopao 5f2aed6
add missing other_subset info
edopao b1579a7
fix test cases
edopao 77edc98
Unclean fixes (revert tuple lowering)
tehrengruber ef4979d
fix for field domain with scalr broadcast
edopao 1a4bf3a
Enable laplacian test
tehrengruber 61c2159
fix memlet subset issue
edopao 65f7fcf
undo extra changes
edopao cadce61
use dynamic memlets for write to output
edopao b2b12e4
prefix tasklet connectors with '__' to avoid name collision with data…
edopao 294f0cf
use temp array, not view, for concat slice
edopao ac0625f
Merge origin/main
tehrengruber b28f1f0
Merge remote-tracking branch 'SF-N/GTIR_concat_where' into gtir-dace-…
edopao 1af561e
Merge origin/main
tehrengruber 1ab8c69
embedded concat_where
havogt 73fba27
Merge branch 'GTIR_concat_where' of github.com:SF-N/gt4py into GTIR_c…
havogt ae07826
add support for more comparison operators
havogt a8fe04e
change Dimension comparison
havogt 40cf33b
embedded: non-python int comparison
havogt eb72671
Merge remote-tracking branch 'SF-N/GTIR_concat_where' into gtir-dace-…
edopao c60492c
add todo comment
edopao 53c2cb7
formatting
edopao 0037278
fix slice memlet
edopao ac522d2
fix broadcast of scalar value
edopao 2feab82
pruning of empty branches is done by gt_simplify
edopao 8c4fc45
Fix import
tehrengruber ac6fbb4
Merge origin/main
tehrengruber 9ef6dd0
Merge branch 'GTIR_concat_where' into gtir-dace-concat_where
tehrengruber 2731432
Merge remote-tracking branch 'origin/main' into GTIR_concat_where
tehrengruber 8ae4b58
Merge branch 'GTIR_concat_where' into gtir-dace-concat_where
tehrengruber bf7ae21
Merge remote-tracking branch 'upstream/main' into GTIR_concat_where
havogt e0d65e4
Merge branch 'GTIR_concat_where' into gtir-dace-concat_where
havogt b8b80f8
Merge origin/main
tehrengruber 1f49b71
Merge remote-tracking branch 'origin_sf_n/GTIR_concat_where' into GTI…
tehrengruber a41eb1a
feat[next]: GTIR concat_where frontend
havogt e2c053c
disable concat_where tests
havogt 4b46fcd
one more it_ts.DomainType
havogt d77a4c0
add test for concat_where on scalars and fix typing
havogt f41c112
add test for chained comparison
havogt de287c2
Merge remote-tracking branch 'origin/main' into GTIR_concat_where
tehrengruber 3a46c71
Merge branch 'main' into GTIR_concat_where
tehrengruber f4861fd
Merge branch 'GTIR_concat_where' into gtir-dace-concat_where
tehrengruber 8a3aef5
Merge remote-tracking branch 'origin_edopao/gtir-dace-concat_where' i…
tehrengruber 13baa21
Merge branch 'main' into GTIR_concat_where
tehrengruber fc329e6
Merge branch 'GTIR_concat_where' into gtir-dace-concat_where
tehrengruber 4d41d86
Merge remote-tracking branch 'origin/main' into GTIR_concat_where
tehrengruber 7cbd2cb
Merge branch 'GTIR_concat_where' into gtir-dace-concat_where
tehrengruber c88adf7
Merge origin/main
tehrengruber 359a921
Fix broken merge
tehrengruber 4764c2b
Simplify tuple lowering, unit tests, cleanup
tehrengruber 62db9ff
Small fix
tehrengruber 7053c39
Cleanup
tehrengruber d597a4d
Cleanup
tehrengruber 45ccbbc
Cleanup
tehrengruber 0326e80
Add more unit tests
tehrengruber d069b67
Merge branch 'main' into GTIR_concat_where
edopao d1ba62f
Merge branch 'GTIR_concat_where' into gtir-dace-concat_where
edopao ebb0831
fix for list index on slice concat_where
edopao ab719d9
fix for new domain on scalars and 1d fields as concat_where args
edopao 1ce4ed4
Cleanup
tehrengruber 62688b2
Cleanup
tehrengruber afdd60c
Merge remote-tracking branch 'origin/main' into GTIR_concat_where
tehrengruber eb9adf9
Cleanup
tehrengruber a7527df
Merge branch 'GTIR_concat_where' into gtir-dace-concat_where
edopao dc98855
Cleanup
tehrengruber 351ca0f
fix pass_manager
edopao b4e5fd1
Cleanup
tehrengruber e1b9d88
Merge commit 'a41eb1a' into GTIR_concat_where
tehrengruber dfd2b14
Merge remote-tracking branch 'origin/main' into concat_where_frontend
tehrengruber ec6b305
Merge branch 'concat_where_frontend' into GTIR_concat_where (#1998)
tehrengruber 0bd26ce
Cleanup
tehrengruber e5dbf4a
Cleanup
tehrengruber 0e8faad
Fix dace
tehrengruber 1ac9719
Merge branch 'GTIR_concat_where' into gtir-dace-concat_where
edopao 77b8efe
Merge branch 'main' into GTIR_concat_where
edopao e215d66
Merge branch 'GTIR_concat_where' into gtir-dace-concat_where
edopao c497022
Merge branch 'main' into GTIR_concat_where
edopao 75c7c1e
Merge branch 'GTIR_concat_where' into gtir-dace-concat_where
edopao cfe389d
Merge branch 'main' into GTIR_concat_where
edopao 4af6f19
Merge branch 'GTIR_concat_where' into gtir-dace-concat_where
edopao 599d8f1
Merge remote-tracking branch 'upstream/main' into concat_where_frontend
havogt 2499389
remove unchain comparison (because doesn't make sense)
havogt 398ec68
improve error messages
havogt f81393a
fix chain test
havogt eae7dc7
simplify typing
havogt 16e1c65
rename
havogt 5f7e251
add promotion tests
havogt b1e8f89
Fix small type inference bug
tehrengruber 35c026e
Merge branch 'main' into GTIR_concat_where
tehrengruber 4feb941
Merge branch 'GTIR_concat_where' into gtir-dace-concat_where
tehrengruber fb01638
Merge branch 'concat_where_frontend' into GTIR_concat_where
tehrengruber 06905b8
Merge branch 'main' into GTIR_concat_where
tehrengruber a66e5ca
Merge remote-tracking branch 'origin/main' into concat_where_frontend
tehrengruber d89cff6
Backport fixes from main PR
tehrengruber 6f9ebff
Merge branch 'concat_where_frontend' into GTIR_concat_where
tehrengruber 3dac495
Cleanup
tehrengruber 506c2b5
Extract concat_where transformations
tehrengruber 8ae99ae
Merge branch 'gtir_concat_where_passes' into GTIR_concat_where
tehrengruber af36bc9
Small fix
tehrengruber f1a99bd
Format
tehrengruber 1f6b284
Format
tehrengruber 45a2e23
Cleanup
tehrengruber 721dde3
Merge branch 'gtir_concat_where_passes' into GTIR_concat_where
tehrengruber 52c96ed
Cleanup
tehrengruber 034c660
Cleanup
tehrengruber c460459
Cleanup
tehrengruber bbf0016
Cleanup
tehrengruber cbeee8e
Cleanup
tehrengruber 9d179c6
Fix infer domain ops
tehrengruber 724b0fe
Merge branch 'main' into gtir_concat_where_passes
havogt a421f79
Fix failing doctest
tehrengruber 56dcbc4
Merge remote-tracking branch 'origin_tehrengruber/gtir_concat_where_p…
tehrengruber f770961
Merge branch 'main' into GTIR_concat_where
edopao d8252b7
Merge branch 'GTIR_concat_where' into gtir-dace-concat_where
edopao aadf582
remove uses_concat_where from COMMON_SKIP_TEST_LIST
edopao 1fcc669
Merge branch 'GTIR_concat_where' into gtir-dace-concat_where
edopao e631f00
set find_new_name=True for concat_where slice
edopao 0957ca9
Merge branch 'main' into GTIR_concat_where
edopao 65c2116
Merge branch 'GTIR_concat_where' into gtir-dace-concat_where
edopao b056955
Merge branch 'main' into GTIR_concat_where
edopao 8a4308b
Merge branch 'GTIR_concat_where' into gtir-dace-concat_where
edopao b23ad21
fix domain in scalar broadcast
edopao fb074fe
Merge branch 'main' into GTIR_concat_where
edopao 08cb3a7
Merge branch 'GTIR_concat_where' into gtir-dace-concat_where
edopao d669e3b
fix merge commit
edopao 80ba402
add test case for coverage of bug in scalar broadcast on empty branch
edopao 4f5f8ae
fix formatting
edopao a090872
bugfix - support for empty branch on 2d/3d concat_where
edopao fc2df23
Merge branch 'main' into GTIR_concat_where
edopao 2bd9d3b
add test cases for empty branches
edopao 7aabf11
Merge branch 'GTIR_concat_where' into gtir-dace-concat_where
edopao 3c78ec1
Merge branch 'main' into GTIR_concat_where
edopao a9e9864
Merge branch 'GTIR_concat_where' into gtir-dace-concat_where
edopao eaf2195
fix domain
edopao f26b312
add extra check for scalar broadcast
edopao 78a61ca
extend test case scalar_broadcast_on_empty_branch
edopao a9f146e
Merge branch 'main' into GTIR_concat_where
edopao 31da410
pre-commit - format code
edopao ad31327
Merge branch 'GTIR_concat_where' into gtir-dace-concat_where
edopao 71f46f3
Merge branch 'main' into GTIR_concat_where
edopao de8e737
Merge branch 'GTIR_concat_where' into gtir-dace-concat_where
edopao 8c642b8
address review comments
havogt 7877f6d
add domain_utils tests
havogt 086910c
refactor domain ops
havogt 73b333d
Merge remote-tracking branch 'upstream/main' into gtir_concat_where_p…
havogt 58a0492
fix formatting
havogt 81b9309
add type inference test
havogt a176174
cleanup
havogt 6a1087d
delete an obsolete assert
havogt a3bdfed
Merge branch 'gtir_concat_where_passes' into GTIR_concat_where
havogt 3678a38
remove embedded implementation
havogt 94ef41a
address review comments
havogt 8c0b1fc
Merge branch 'gtir_concat_where_passes' into GTIR_concat_where
havogt 8a9a172
Merge remote-tracking branch 'upstream/main' into GTIR_concat_where
havogt de19ee9
fix merge conflict
havogt 0feead0
document some tests
havogt 7ba38d5
fix test structure in constant folding
havogt 4722c05
remove resolved todos
havogt 06a70e3
refactorings
havogt d3bcc56
Merge remote-tracking branch 'upstream/main' into GTIR_concat_where
havogt 9a116c1
cleanup test
havogt 8635b2c
fix[next]: symbol clash in inline_lambda
havogt ac442f5
Merge branch 'fix_symbol_clash_inline_lambda' into GTIR_concat_where
havogt c72f494
cleanup
havogt 8fa1a75
Merge branch 'fix_symbol_clash_inline_lambda' into GTIR_concat_where
havogt 9fe9c5c
address review comments
havogt 8f71edf
cleanup todo
havogt 47be113
Merge remote-tracking branch 'upstream/main' into GTIR_concat_where
havogt 5d35a75
Merge remote-tracking branch 'SF-N/GTIR_concat_where' into gtir-dace-…
edopao 830543b
ignore type errors
edopao 7bfa394
Merge remote-tracking branch 'origin/main' into gtir-dace-concat_where
edopao c46ec9e
enable tests
edopao e6c3f96
Merge remote-tracking branch 'origin/main' into gtir-dace-concat_where
edopao b439c8b
remove boundary check (dbg)
edopao c34b7d0
move concat_where to separate module
edopao ae00f66
move inner function outside
edopao fb57138
Merge remote-tracking branch 'origin/main' into gtir-dace-concat_where
edopao 84e11b5
fix pre-commit
edopao c6ce1c2
edit comment
edopao ed3fb83
Revert "remove boundary check (dbg)"
edopao cdc6cb0
fix
edopao a43079e
broadcast scalar concat_where input to temp array
edopao a22a572
Merge remote-tracking branch 'origin/main' into gtir-dace-concat_where
edopao 5729017
address review comments
edopao 25871b9
add code examples in comments
edopao db15652
add code examples in comments (1)
edopao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.