Skip to content

Add python 3.13, 3.14, drop < 3.10 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tehrengruber merged 12 commits into from
Feb 6, 2026
Merged

Add python 3.13, 3.14, drop < 3.10 #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ae95b1e
Add python 3.13
havogt Jun 25, 2025
3d3aabb
Update pyproject.toml
havogt Jun 25, 2025
c90e0ca
Update tox.ini
havogt Jun 25, 2025
07c8d24
Update tox.yml
havogt Jun 25, 2025
0f65f8f
Add python 3.14
havogt Feb 4, 2026
3cd5f19
Update cibuildwheel
tehrengruber Feb 4, 2026
cb4ae3d
Bump macos to macos-15-intel
tehrengruber Feb 4, 2026
9150c37
Fix ci error
tehrengruber Feb 4, 2026
966e8a7
Fix ci error
tehrengruber Feb 4, 2026
43ccede
Fix ci error
tehrengruber Feb 4, 2026
d5ca665
Fix ci error
tehrengruber Feb 4, 2026
09a8436
Use macos latest again
tehrengruber Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions .github/workflows/cibuildwheel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,24 +15,28 @@ jobs:
os:
- ubuntu-latest
- ubuntu-24.04-arm
- macos-13 # x86
- macos-latest # arm
python: ["cp39", "cp310", "cp311", "cp312"]
- macos-15-intel # x86
- macos-latest # arm
python: ["cp310", "cp311", "cp312", "cp313", "cp314"]
steps:
- uses: actions/checkout@v4
- name: Build binary wheels
uses: pypa/cibuildwheel@v2.19
with:
output-dir: dist
- uses: actions/checkout@v6
- name: Install cibuildwheel
run: python -m pip install cibuildwheel==3.3.1

- name: Build wheels
run: |
if [ "$(uname -s)" = Darwin ]; then
export MACOSX_DEPLOYMENT_TARGET="$(sw_vers -productVersion | awk -F. '{print $1 ".0"}')"
fi
python -m cibuildwheel --output-dir dist
Comment on lines +22 to +31
Copy link
Contributor Author

@havogt havogt Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? Did you check if there is a way to figure out MACOSX_DEPLOYMENT_TARGET with the action. Sounds like a common pattern.

Copy link
Contributor

@tehrengruber tehrengruber Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without it, it breaks and cmake selects version 10.xx which is incompatible with some of the system provided libraries we pull in (lz4 I think). There is no specific info about this in the action, I assume because this is a CMAKE option. What I don't understand is why the option is needed in the first place, I don't think this is required when building locally on a Mac.

env:
# Wheel version settings
CIBW_BUILD: ${{matrix.python}}-*
CIBW_SKIP: pp* *musllinux*
# Linux archs
CIBW_ARCHS_LINUX: ${{ fromJSON('["x86_64", "aarch64"]')[matrix.os == 'ubuntu-24.04-arm'] }} # poor man ternary https://github.com/orgs/community/discussions/25725#discussioncomment-3248924
# MacOS archs
CIBW_ARCHS_MACOS: ${{ fromJSON('["arm64", "x86_64"]')[matrix.os == 'macos-13'] }}
MACOSX_DEPLOYMENT_TARGET: ${{ fromJSON('["14.0", "13.0"]')[matrix.os == 'macos-13'] }}
CIBW_ARCHS_MACOS: ${{ fromJSON('["arm64", "x86_64"]')[matrix.os == 'macos-15-intel'] }}
# General
CIBW_TEST_REQUIRES: -r requirements-dev.txt
CIBW_TEST_COMMAND: pytest -v {project}/tests
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tox.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
python-version: ["3.10", "3.11", "3.12", "3.13", "3.14"]

steps:
- uses: actions/checkout@v4
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ classifiers = [
"Operating System :: POSIX :: Linux",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Programming Language :: Python :: 3.14",
"Programming Language :: Python :: Implementation :: CPython",
"Topic :: Scientific/Engineering :: Atmospheric Science",
]
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
[tox]
min_version = 4.0
envlist =
py{36,37,38,39,310,311,312}
py{310,311,312,313,314}

[testenv]
deps = -r {toxinidir}/requirements-dev.txt
Expand Down
Loading