Fix Large Boiler Preview #2873
Open
Fix Large Boiler Preview #2873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghzdude
added
type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes the JEI preview for the Large Boilers due to an oversight from #2420. Since fluid hatches have the IMPORT_ITEMS ability, they count towards the max limit and conflict with the IMPORT_FLUIDS ability predicate. The better and ideal solution (i think) would require a larger rework and discussion on ability predicates.
Implementation Details
the max global count for
IMPORT_ITEMSto twoset preview count for
IMPORT_ITEMSandIMPORT_FLUIDSto 1Outcome
Large Boiler is now formed correectly in the JEI preview