Add method to MetaValueItem to create an ItemStack with capability NBT #2867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zorbatron
changed the title
ghzdude
reviewed
Oct 19, 2025
Comment on lines
+52
to
+57
| int index = 0; | ||
| for (ICapabilityProvider provider : providers) { | ||
| if (provider instanceof INBTSerializable<?>serializable) { | ||
| tag.setTag(String.valueOf(index++), serializable.serializeNBT()); | ||
| } | ||
| } |
There was a problem hiding this comment.
i'd probably use an indexed for loop since that's basically what you're doing anyways
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a method to
MetaValueItemto create anItemStacks capabilities with a certain NBT tag.Idk why forge decided to have capabilities act on a separate NBT tag than the one of the item stack.