Skip to content

Conversation

@MCTian-mi
Copy link
Contributor

What

All child classes of BlockMaterialPipe has such impl themselves, although it's not exactly the same.

@MCTian-mi MCTian-mi requested a review from a team as a code owner August 22, 2025 10:04
@Zorbatron Zorbatron added the type: refactor Suggestion to refactor a section of code label Aug 25, 2025
@Zorbatron
Copy link
Member

These common method using enabledMaterials can also be moved down to BlockMaterialPipe:

  • createProperties
  • getFallbackType
  • getSubBlocks
  • addPipeMaterial

@MCTian-mi
Copy link
Contributor Author

These common method using enabledMaterials can also be moved down to BlockMaterialPipe:

  • createProperties
  • getFallbackType
  • getSubBlocks
  • addPipeMaterial

Done!

@MCTian-mi MCTian-mi requested a review from a team as a code owner September 4, 2025 13:59
@ALongStringOfNumbers ALongStringOfNumbers merged commit 5c70731 into GregTechCEu:master Oct 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: refactor Suggestion to refactor a section of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants