Rework Item Handler List #2821
Draft
Rework Item Handler List #2821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add methods to simplify handler logic improve handler list adding improve get add immutable handler list improve handler list tests
and pass to inner handlers
don't throw in `getIndexOffset()`
implement indexOf() implement lastIndexOf() remove braces
use methods instead of field access improve immutable tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Reworks ItemHandlerList to be more like a list. You can now add/remove handlers from the list as you would expect, and there is an immutable version as well. Introduces tests to ensure ItemHandlerList works as expected.
Implementation Details
you can add/remove handlers
set is not supported atm
list implements notifiable and delegates those calls to internal handlers
new tests for list operations
should item handler list be final? along with the immutable class?
Outcome
This wouldn't have any user-facing changes, but it makes ItemHandlerList easier to work with as devs