Port Singleblock Recipemap Machines + Generators to MUI2 #2808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghzdude
force-pushed
the
gh/sb-recipe-map-mui
branch
from
d417cfc to
c35a8d2
Compare
M-W-K
reviewed
May 19, 2025
| * @return this | ||
| */ | ||
| @Deprecated | ||
| @ApiStatus.ScheduledForRemoval(inVersion = "2.9") |
There was a problem hiding this comment.
Isn't our next release going to be 2.9? Probably ought to schedule removal for 2.10 or so.
use builder consumer
add a few more overloads
update as many singleblock machines to mui2
spotless
fix special texture use GTFluidSlot instead of FluidSlot use IDrawable.of() for slot overlays
set max inputs before ui build split overlay maps into Int2Obj maps pull pos out of make slot methods
simplify usesMui2 checks
add todos for fluid slot
src/main/java/gregtech/common/metatileentities/steam/boiler/SteamBoiler.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/common/metatileentities/steam/boiler/SteamLavaBoiler.java
Show resolved
Hide resolved
src/main/java/gregtech/api/metatileentity/SteamMetaTileEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/api/metatileentity/SimpleMachineMetaTileEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/api/metatileentity/SimpleGeneratorMetaTileEntity.java
Outdated
Show resolved
Hide resolved
address todo
add debug names clarify some variable names calculate the grid size for both items and fluids
|
Painting a machine doesn't change its UI color and the |
|
Also, we think that we should implement the side column, like in multiblocks and hatches, for clearing out some space in the GUI. See the discussion starting here: https://discord.com/channels/701354865217110096/904846945095385138/1408285204795359292 |
use qualified references for old gui class references
improve overlay map
fix generator ui
remove `+ 9`
move special machine widgets around
construct panel in map ui adjust height to remove empty space
add heat tooltip + lang in SteamBoiler add todo for SteamMetaTileEntity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Ports every singleblock Recipemap machine and generator, along with steam machines/boilers, to MUI2
Built off of the
sb-recipe-map-muibranchImplementation Details
adds
usesMui2()to SimpleGeneratorMTE, SimpleMachineMTE, and SteamMTE to defer to recipe map ui'susesMui2()steam boilers ui is manually constructed, and therefore ported directly to Mui2
slot overlays for mui2 are stored in an Int2Obj map, with the key being the slot index
adds
RecipeProgressWidgetto allow for JEI searchingadds
RecipeMapUIBuilderfor building the mui2 slot overlaysdeprecate old mui code and methods
Outcome
the last set of uis should be ported to mui2