Open
Conversation
Collaborator
|
@Ewan88 thank you for you contribution! can you split this to two PR, it is good for code maintenance and review. |
Contributor
Author
Collaborator
|
@Ewan88 there is a conflict, can you solve it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change sets the local storage value for embed from the url - previously it was always false, regardless of url param.
Also fixes a CSS issue with a horizontal scrollbar appearing, despite there being no extra content.
Fixes #1674
Type of change
How Has This Been Tested?
Checklist: