Feat: cwm select input for font weight#1655
Feat: cwm select input for font weight#1655khalatevarun wants to merge 1 commit intoGreenstand:cwmfrom
Conversation
|
@RubenSmn i have a blocker here, i understood why we have loadWeight function but did not really understand how does it work, where do we show the loader component now after adding select menu? Also, please review the code removed in handleChange and loadWeight functions since it seemed unnecessary after adding select input |
RubenSmn
left a comment
There was a problem hiding this comment.
The change logic looks good, maybe we can use the IconComponent prop on the Select component to change the icon to a loading spinner. This will give the user a indication that the new font are being loaded.
We could even manually control the open state of the select and only close the select dropdown when the font weight has successfully loaded.
|
When will the loading spinner appear is my question, not able to reproduce a scenario where I can test it |
|
@dadiorchen can you please help here answering my doubt? |
|
@khalatevarun we have a loading state for when we're loading the new font weights. If its true we can show to loader. Does this answer your question? |
|
@khalatevarun are you facing any issues? |
Description
Fixes #1636
Type of change
Screenshots
How Has This Been Tested?
Checklist: