Open
Conversation
Member
Author
|
@dadiorchen we should consider this. It will greatly improve the UI of our icons, especially on mobile. |
Collaborator
|
@RubenSmn okay, I will download this and run it to check locally, can you fix the conflict for me? |
b4f57b4 to
a51fc60
Compare
Member
Author
|
@dadiorchen done! |
Collaborator
|
@RubenSmn do you think this is still valid or we can close it? |
Member
Author
|
@dadiorchen I think it still could be valuable since it standardizes the size of a icon. For example on the top page: https://beta-map.treetracker.org/top the tree icons on the leader board have a incorrect size. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Will improve the resizing on mobile, first it was a fixed
28pxnow it is75%of the initial(desktop) value.All can be overridden with the
sxprop, a good example is in theImpactSection.Reason for the change is that there is no need to set a different
heightandwidthsince the svg will be rendered as a square anyway.sizeprop toCustomIconcomponentsizepropType of change
Checklist: