Prevent self-referencing in trusted wallets list#162
Merged
samwel141 merged 2 commits intoGreenstand:v2from Nov 16, 2025
Merged
Prevent self-referencing in trusted wallets list#162samwel141 merged 2 commits intoGreenstand:v2from
samwel141 merged 2 commits intoGreenstand:v2from
Conversation
Check trust relationships against the logged-in wallet to ensure the trusted wallets list never includes the wallet itself. Previously used actor_wallet_id which could incorrectly include the logged-in wallet. - Add checkLoggedInWalletId to return the other wallet in the relationship - Add checkLoggedInWalletName to return the other wallet's name - Ensures trusted wallets list only shows wallets that trust or are trusted by the logged-in wallet, not the wallet itself
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where the trusted wallets list could incorrectly include the logged-in wallet itself.
The fix adds helper functions that check the trust relationship against the logged-in wallet to ensure only the "other" wallet in the relationship is returned, preventing the logged-in wallet from appearing in its own trusted wallets list.
Tasks Completed
checkLoggedInWalletIdhelper function to determine the correct wallet ID (the other wallet in the relationship)checkLoggedInWalletNamehelper function to determine the correct wallet namegetTrustedWalletsto use the new helper functions