Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to verify existence of search related to search job #22038

Merged

Conversation

luk-kaminski
Copy link
Contributor

Description

No need to verify existence of search related to search job.
/nocl

Motivation and Context

FE does not use search ID stored in search job to fetch a search.
Each execution results in the creation of a new search.
Even if the search job is linked to a search that is gone, we should not take any immediate actions, throw exceptions etc.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Sorry, something went wrong.

@luk-kaminski luk-kaminski requested a review from janheise March 19, 2025 13:47
@luk-kaminski luk-kaminski merged commit 48ca6c4 into master Mar 20, 2025
6 checks passed
@luk-kaminski luk-kaminski deleted the data_lake/no_need_to_verify_search_job_existence branch March 20, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants