Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the datanode upgrade list when we wait for a node to be upgraded #22037

Merged
merged 2 commits into from
Mar 21, 2025
Merged

Show the datanode upgrade list when we wait for a node to be upgraded #22037

merged 2 commits into from
Mar 21, 2025

Conversation

gally47
Copy link
Contributor

@gally47 gally47 commented Mar 19, 2025 •
edited
Loading

Motivation and Context

fixes #22004

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gally47 gally47 self-assigned this Mar 19, 2025
@gally47 gally47 requested a review from moesterheld March 19, 2025 14:57
moesterheld
moesterheld approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@moesterheld moesterheld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thank you for the fix

@moesterheld moesterheld merged commit 220d052 into master Mar 21, 2025
7 checks passed
@moesterheld moesterheld deleted the fix-22004 branch March 21, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moesterheld moesterheld moesterheld approved these changes

Assignees

@gally47 gally47

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix datanode upgrade list hidden when we are waiting for one data node to be upgraded
2 participants
@gally47 @moesterheld