Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISW - Fix new stream form values lost when going back #22033

Merged
merged 3 commits into from
Mar 20, 2025
Merged

ISW - Fix new stream form values lost when going back #22033

merged 3 commits into from
Mar 20, 2025
+25 −10

Conversation

laura-b-g
Copy link
Contributor

Description

/nocl
fixes #22020

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Sorry, something went wrong.

@laura-b-g laura-b-g requested review from ousmaneo and gally47 March 19, 2025 11:16
gally47
gally47 requested changes Mar 19, 2025
View reviewed changes
...2-web-interface/src/components/inputs/InputSetupWizard/steps/components/CreateStreamForm.tsx
submitForm,
handleBackClick,
prevCreatedStream = undefined,
prevShouldCreateNewPipeline = true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we use useInputSetupWizardSteps hook here to get stepsData instead of passing props?

Copy link
Contributor Author

@laura-b-g laura-b-g Mar 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, but in this case I wanted to keep this component as "dumb" as possible on purpose, just having the form and it's markup and leave dealing with the state and data up to the parent component to reduce complexity.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component is not really "dumb" it is fetching the indexSets, it's fine for me if we keep it as it is, but I do think it's not optimal and scalable specially if we keep needing more and more props when we can just use the already existing context data.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, if it ends up needing more props we should think about using the context instead.

@gally47 gally47 self-requested a review March 20, 2025 09:20
gally47
gally47 approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@gally47 gally47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@laura-b-g laura-b-g merged commit 427723b into master Mar 20, 2025
6 of 7 checks passed
@laura-b-g laura-b-g deleted the fix/22020/isw-create-stream-back branch March 20, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gally47 gally47

@ousmaneo ousmaneo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Input Setup Wizard: Back button loses previously entered new stream info
2 participants
@laura-b-g @gally47