Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to make auto refresh context optional #21984

Conversation

maxiadlovskii
Copy link
Contributor

@maxiadlovskii maxiadlovskii commented Mar 14, 2025

Description

In some cases, we need to use auto refresh context functionality in reusable components, but not everywhere where we use these reusable components refresh functionality is required. I want to avoid the situation where we have to put unnecessary providers or turn off the error throwing which checks if context was defined. For that, I add into the hook flag which can explicit point that this context might be optional and returns some empty callbacks

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
    /nocl

@maxiadlovskii maxiadlovskii requested a review from linuspahl March 14, 2025 12:58
@maxiadlovskii maxiadlovskii deleted the refactoring/Add-flag-with-optinal-autorefresh-context branch March 21, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant