Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing dependency on Content Pack creation for Searches with Parameters (6.0) #21855

Draft
wants to merge 4 commits into
base: 6.0
Choose a base branch
from

Conversation

janheise
Copy link
Contributor

@janheise janheise commented Mar 4, 2025

Description

backport of #21563

TODO: the changes are not sufficient. There were additional code changes by TDIR that were added with 6.1 that this PR would also need to work. So we postpone this PR

Prior to this PR, the Data Lookup Adapter was not shown as a dependency on Content Pack creation for a search that includes parameters. This creates issues on importing the Content Pack because errors regarding the lookup of a Data Adapter that is missing are mostly only bubbling up in the logs, not the FE (at least not readable).

This PR does not address the problems during import - we will address this in another PR because this is not only related to Searches - but reduces errors made during Content Pack creation so that the dependency is in the Content Pack unless explicitly removed.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Sorry, something went wrong.

@janheise janheise marked this pull request as draft March 5, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant