Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typecast enum values in Rest API Schema #1574

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

jakejackson1
Copy link
Member

@jakejackson1 jakejackson1 commented Sep 5, 2024

Description

Fix validation error when enum values are integers but the expected type is a string

Checklist:

  • I've tested the code.
  • My code is easy to read, follow, and understand
  • My code follows the accessibility standards.
  • My code has proper inline documentation / docblocks.

Additional Comments

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.82%. Comparing base (50e1283) to head (cc21c55).
Report is 4 commits behind head on development.

Files with missing lines Patch % Lines
src/Rest/Rest_Form_Settings.php 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           development    #1574   +/-   ##
============================================
  Coverage        77.82%   77.82%           
============================================
  Files              255      255           
  Lines            13896    13899    +3     
  Branches           370      370           
============================================
+ Hits             10814    10817    +3     
  Misses            3074     3074           
  Partials             8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakejackson1 jakejackson1 merged commit 7521ef1 into development Sep 5, 2024
12 of 13 checks passed
@jakejackson1 jakejackson1 deleted the rest-api-schema-enum branch September 5, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant