Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Form PDF Settings to be previewed before saving #1563

Merged
merged 1 commit into from
Aug 30, 2024

Add Preview PDF feature to Form PDF Settings

141c78b
Select commit
Loading
Failed to load commit list.
Merged

Allow Form PDF Settings to be previewed before saving #1563

Add Preview PDF feature to Form PDF Settings
141c78b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 30, 2024 in 1s

77.83% (+0.53%) compared to c1dbd83

View this Pull Request on Codecov

77.83% (+0.53%) compared to c1dbd83

Details

Codecov Report

Attention: Patch coverage is 86.25430% with 40 lines in your changes missing coverage. Please review.

Project coverage is 77.83%. Comparing base (c1dbd83) to head (141c78b).
Report is 2 commits behind head on development.

Files with missing lines Patch % Lines
src/Model/Model_PDF.php 20.58% 27 Missing ⚠️
src/Rest/Rest_Form_Settings.php 94.15% 10 Missing ⚠️
src/bootstrap.php 90.47% 2 Missing ⚠️
src/Rest/Rest_Pdf_Preview.php 97.95% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1563      +/-   ##
===============================================
+ Coverage        77.29%   77.83%   +0.53%     
===============================================
  Files              251      252       +1     
  Lines            13780    13920     +140     
  Branches           370      370              
===============================================
+ Hits             10651    10834     +183     
+ Misses            3121     3078      -43     
  Partials             8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.