-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font manager - tabIndex attribute enhancement #1279
base: development
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## development #1279 +/- ##
=================================================
- Coverage 23.35% 23.34% -0.01%
Complexity 2876 2876
=================================================
Files 242 242
Lines 9807 9806 -1
Branches 364 361 -3
=================================================
- Hits 2290 2289 -1
Misses 7509 7509
Partials 8 8
Continue to review full report at Codecov.
|
5cdb7c1
to
e56fe08
Compare
@@ -333,7 +333,7 @@ export class FontListItems extends Component { | |||
const { disableSelectFontName, deleteId } = this.state | |||
const { id, loading, fontList, searchResult, selectedFont } = this.props | |||
const list = !searchResult ? fontList : searchResult | |||
const tabIndex = updateFontVisible ? '-1' : '144' | |||
const tabIndex = updateFontVisible ? '-1' : '0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@debbieellis7 this line could be removed now, right?
@jestonihpi this PR needs to be rebased on development, force pushed, and then tested. |
e56fe08
to
0021da0
Compare
I've just rebased this branch @kielllll |
Description
Issue: #1206
Testing instructions
Screenshots
Checklist:
Additional Comments