Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmation on unsaved settings. #1277

Closed

Conversation

debbieellis7
Copy link
Contributor

@debbieellis7 debbieellis7 commented Apr 26, 2021

Description

Issue: #1250

Pop-up confirmation on PDF settings unsaved changes.

Testing instructions

Screenshots

Checklist:

  • I've tested the code.
  • My code is easy to read, follow, and understand
  • My code follows the accessibility standards.
  • My code has proper inline documentation / docblocks.

Additional Comments

@debbieellis7 debbieellis7 requested a review from jestonihpi April 26, 2021 01:21
@debbieellis7 debbieellis7 added this to the 6.x milestone Apr 26, 2021
@debbieellis7 debbieellis7 linked an issue Apr 26, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #1277 (3b45b05) into development (0a90239) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #1277   +/-   ##
==============================================
  Coverage          21.71%   21.71%           
  Complexity          2967     2967           
==============================================
  Files                244      244           
  Lines              11346    11346           
  Branches             364      364           
==============================================
  Hits                2464     2464           
  Misses              8874     8874           
  Partials               8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a90239...3b45b05. Read the comment docs.

@debbieellis7 debbieellis7 force-pushed the unsaved-settings-alert-confirmation branch from 4b2b85c to 3b45b05 Compare April 27, 2021 00:35
Copy link
Contributor

@jestonihpi jestonihpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmation box is now working on pdf settings and license tab.

@jakejackson1
Copy link
Member

Partially implemented in #1563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDF Settings - Confirmation on unsaved settings.
3 participants