Skip to content

Conversation

@divyanshu-rawat
Copy link

Initially, When triggering Login model There was no left & right padding wrt browser window when screen size was xs or sm.
I fixed it by adding 5% padding to .modal-dialog class
Kindly review the pull request.

Regards
Divyanshu Rawat

@divyanshu-rawat
Copy link
Author

I checked out to the "Change Travis badge and repo URL" commit(latest commit on the repo) & executed gulp test
And Concluded that tests were already broken in the commit.
I don't think that any of the tests are broken by my changes.
I am attaching a snapshot below

screenshot from 2017-03-05 23 22 06

@divyanshu-rawat
Copy link
Author

@atfornes Please Look into this.

@divyanshu-rawat
Copy link
Author

@atd please look at this.
tests were broken in the past my modifications to the existing code haven't affected any of the tests.

@atfornes
Copy link

atfornes commented Mar 7, 2017

Sorry @divyanshu-rawat, but the contributions of GSoC applicants should wait as we explain in the wiki: https://cyber.harvard.edu/gsoc/GSoC_FAQ#Can_I_start_contributing_now.3F.21

I am sorry I have not let you know earlier, but I forgot about this agreement we have to follow.

Thanks again anyway :) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants