This repository was archived by the owner on Jun 7, 2020. It is now read-only.
Guard #19
Open
Guard #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svtz
suggested changes
May 8, 2018
| @@ -35,6 +37,7 @@ public GraphLabsContextImpl(GraphLabsContext ctx) | |||
| private Type GetEntityTypeFor(Type type) | |||
| { | |||
| Contract.Assert(typeof(AbstractEntity).IsAssignableFrom(type)); | |||
| Guard.Guard.AreAssignedTypes(typeof(AbstractEntity), type); //* | |||
There was a problem hiding this comment.
Нужно зайти в настройки проекта Guard, и там поменять deafult namecpacе: вместо GraphLabs.Guard написать GraphLabs. После чего поменять пространство имён для класса Guard аналогичным образом.
| @@ -18,6 +18,7 @@ public class ChangesTracker : IChangesTracker | |||
| public ChangesTracker(GraphLabsContext context) | |||
| { | |||
| Contract.Requires(context != null); | |||
| Guard.Guard.IsNotNull(context, nameof(context) ); //* | |||
|
|
||
| get | ||
| { | ||
| Guard.Guard.IsNotNull(_originalValues.Value, nameof(_originalValues.Value)); |
There was a problem hiding this comment.
тут вернуть как было, значение реально может быть null и это ок
| get { return _currentValues.Value; } | ||
| get | ||
| { | ||
| Guard.Guard.IsNotNull(_currentValues.Value, nameof(_currentValues.Value)); |
| @@ -28,59 +29,66 @@ public RepositoryFactory(GraphLabsContext context, ISystemDateService systemDate | |||
| public IGroupRepository GetGroupRepository() | |||
| { | |||
| Contract.Ensures(Contract.Result<IGroupRepository>() != null); | |||
|
|
|||
| return new GroupRepository(_context); | |||
| GroupRepository groupRepository = new GroupRepository(_context); | |||
There was a problem hiding this comment.
@использовать var вмеcто GroupRepository
| } | ||
|
|
||
| /// <summary> Получить репозиторий с группами </summary> | ||
| [NotNull] | ||
| public ISessionRepository GetSessionRepository() | ||
| { | ||
| Contract.Ensures(Contract.Result<ISessionRepository>() != null); | ||
|
|
||
| return new SessionRepository(_context, _systemDateService); | ||
| SessionRepository sessionRepository = new SessionRepository(_context, _systemDateService); |
| } | ||
|
|
||
| /// <summary> Получить репозиторий с лабораторными работами </summary> | ||
| [NotNull] | ||
| public ILabRepository GetLabRepository() | ||
| { | ||
| Contract.Ensures(Contract.Result<ILabRepository>() != null); | ||
|
|
||
| return new LabRepository(_context, _tasksContext); | ||
| LabRepository labRepository = new LabRepository(_context, _tasksContext); |
| <package id="xunit.abstractions" version="2.0.1" targetFramework="net452" /> | ||
| <package id="xunit.JetBrains" version="1.9.2" targetFramework="net452" /> | ||
| <package id="xunit.runner.utility" version="2.3.1" targetFramework="net452" /> | ||
| <package id="YamlDotNet.Signed" version="4.2.1" targetFramework="net452" /> |
There was a problem hiding this comment.
здесь явно слишком много зависимостей. должны быть только R#-аннотации
| Contract.Ensures( | ||
| Contract.Result<LoginResult>() != LoginResult.Success & Contract.ValueAtReturn(out sessionGuid) == Guid.Empty || | ||
| Contract.Result<LoginResult>() == LoginResult.Success & Contract.ValueAtReturn(out sessionGuid) != Guid.Empty); | ||
| Guard.Guard.IsTrueAssertion(default(LoginResult) != LoginResult.Success & sessionGuid == Guid.Empty || | ||
| default(LoginResult) == LoginResult.Success & sessionGuid != Guid.Empty); | ||
|
|
||
| return default(LoginResult); | ||
| } |
| Guard.Guard.IsTrueAssertion(IpHelper.CheckIsValidIP(clientIp)); | ||
| Guard.Guard.IsTrueAssertion(TryLoginImpl(email, password, clientIp, ref sessionGuid, force: false) != LoginResult.Success & sessionGuid == Guid.Empty || | ||
| TryLoginImpl(email, password, clientIp, ref sessionGuid, force: false) == LoginResult.Success & sessionGuid != Guid.Empty); | ||
| return TryLoginImpl(email, password, clientIp, ref sessionGuid, force: false); |
There was a problem hiding this comment.
надо var result = TryLoginImpl(...)
а потом все проверки
vinogradovaanna
commented
May 31, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.