Improve logseq tag handling #1083
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryneeverett
approved these changes
Jan 8, 2025
|
Pinging @scross01 for possible input. |
The prefix causes taskwarrior to throw a "Malformed entry" error when applying a coefficient to the tag.
This ensures that page link-style tags are not inadvertently combined into a single match.
- The leading '#' is removed from the example tags. - Typos are corrected.
Three logseq-compatible tags are added to the test record: two in the
'page link' format and one in the conventional 'tag' format. The
expected results demonstrate:
- issue title: page link double brackets are replaced with special
characters for taskwarrior compatibility
- tags:
- the conventional tag is added first
- non-greedy regex matching prevents the inadvertent combination of
the two page link tags into a single tag
- the leading `#` is stripped from all tags
For improved maintainability, the logseq block URI in the expected results is now dynamically assigned by concatenating the base URI with the test record UUID.
Logseq supports several syntaxes, including:
I'll try to illustrate the issue with an example procedure:
By switching to non-greedy matching, the two page link-style tags are matched separately, resulting in the correct final list, Hope that makes sense! |
|
Nice fix. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two fixes:
#tag prefix to avoid "Malformed entry" errors in Taskwarrior when applying coefficients to tags.The relevant documentation is also updated.