Fix idle-state audio handling and tray balloon messaging - #41
Conversation
Settle-Delay greift jetzt auf Zeitabstand seit letztem Teardown statt auf den physischen BT-Link — der Zombie-Retry-Loop rauschte sonst ohne Delay in UnknownFailure. Diagnose-Logging für StateChanged, reason-Tag am Disconnect und Grund-Logging in IsDeviceConnected. TaskbarIcon und ContextMenu haben expliziten DataContext auf das Window, behebt die OpenCommand/ExitCommand BindingExpression-Fehler.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 300c59e83e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Automatische Zombie-Erkennung und Peak-Metering entfernt (NAudio-Abhängigkeit entfällt) - Recovery-Logik auf manuelle UX umgestellt: „Reconnect“-Button im Hauptfenster und Tray-Menü - Automatischer Reconnect nur noch bei echtem Verbindungsverlust oder Initial-Fehlschlag, max. 2 Versuche à 3s - Nach erschöpften Versuchen klare Nutzerführung: „AUDIO LOST - CLICK CONNECT“ - ViewModel und Service-Interfaces entsprechend vereinfacht und restrukturiert - UI: Split-Button-Animation für „CONNECT“ → „RECONNECT“/„DISCONNECT“ - Tests umfassend angepasst und erweitert, keine versteckten Idle-Recoverys mehr - Lessons- und Todo-Dokumentation aktualisiert - Build und Tests fehlerfrei
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 487166dec4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Add explicit IsRecoverableConnectionLoss state to distinguish full Connect from one-shot Reconnect - Implement bounded auto-reconnect (2 attempts, 3s spacing) for real connection loss - Add physical-aware fallback: AUDIO LOST guides to Reconnect if BT link remains, else Connect - Add ShowReconnectActions/ShowConnectAction computed properties for UI visibility - Update BluetoothConfigView.xaml triggers to use ShowReconnectActions instead of IsConnected - Rewrite MainViewModelTests to validate recoverable state, physical fallback, and no idle-time hidden recycling
|
@codex review again, i want do approve the pr |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1ea6e40221
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex okay can I approve now? |
|
To use Codex here, create an environment for this repo. |
@codex, no i just want to know, if i can approve |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 553f18c72d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…nnection.GetDeviceSelector() presence as the “physical link still up” signal for \SNK devices. IsBluetoothPhysicallyConnectedAsync(...) no longer depends on System.Devices.Aep.IsConnected, and device discovery now uses the same selector-backed source of truth, which keeps the fallback on Reconnect when Windows still exposes the remote source. IAudioService.cs (line 50) now documents that contract.
1 participant
Summary
MainViewModelandAudioServiceto better handle playback transitionsTesting