Increased audit dependencies#163
Open
harsh-hak wants to merge 3 commits intoGopher-Industries:masterfrom
Open
Conversation
elanlaw1206
reviewed
Dec 17, 2025
Contributor
elanlaw1206
left a comment
There was a problem hiding this comment.
Hi Harsh,
This looks good , adding npm audit --audit-level=high to the workflow is a sensible security visibility step, and keeping it non-blocking is fine at this stage.
One small ask: this PR currently includes some unrelated files/changes. Could you please split this so it only contains the workflow update to .github/workflows/security-assessment.yml? That will keep the change focused and easier to track.
Once scoped to the workflow-only change, this is good to go
Thanks!
King Hei
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of the change:
Automated Vulnerability Scanning: I inserted the command npm audit --audit-level=high to run immediately after dependencies are installed. This scans your project's dependencies for known security vulnerabilities with a "high" severity rating.
Non-Blocking Execution: I added continue-on-error: true to this step. This ensures that if vulnerabilities are found, they are logged for your review, but they do not stop the rest of your custom security assessment script from running.