test #4950
Draft
test #4950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change modifies the HCL writer to automatically replace any string attribute value starting with "unknown." with a Terraform variable reference (e.g. "unknown.my_var" -> var.my_var). It also: - Collects all such variables used during the conversion. - Appends `variable` blocks for each unique variable to the end of the generated HCL file, with `type = string`. - Removes the usage of `hcl/printer` (v1) in favor of `hclwrite`'s built-in formatting (v2), to support HCL2 syntax like `type = string`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the HCL writer to automatically replace any string attribute value starting with "unknown." with a Terraform variable reference (e.g. "unknown.my_var" -> var.my_var).
It also:
variableblocks for each unique variable to the end of the generated HCL file, withtype = string.hcl/printer(v1) in favor ofhclwrite's built-in formatting (v2), to support HCL2 syntax liketype = string.