feat: create a C++ sample plugin for HMAC cookie authorization. #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
martijneken
reviewed
Oct 16, 2024
mpwarres
reviewed
Jan 15, 2025
mpwarres
approved these changes
Mar 5, 2025
| const auto path = getRequestHeader(":path")->toString(); | ||
| if (computeHmacSignature(path) != token.value()) { | ||
| const std::optional<std::pair<std::string, std::string>> payload_and_hash = | ||
| parseAuthorizationCookie(token.value()); |
Collaborator
There was a problem hiding this comment.
optional: can dereference using *token instead of token.value(), since has_value() has been checked earlier. *token is shorter and doesn't have behavior that depends on build mode (i.e. whether or not to throw an exception)
| FilterHeadersStatus onRequestHeaders(uint32_t headers, | ||
| bool end_of_stream) override { | ||
| const auto token = getTokenFromCookie(); | ||
| const std::optional<std::string> ip = getClientIp(); |
Collaborator
There was a problem hiding this comment.
Nice structuring of this method! The factoring of checks/parsing into helper methods make it very clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin is a HMAC cookie authorization showcase.
Technically, this is performed by ensuring that the request has a valid HMAC cookie.
This examples contains only a C++ version.