fix(rails): update Dockerfile #1580
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumaripuja-ssk
commented
Jul 25, 2025
kumaripuja-ssk
commented
- Updated URLs in Docker file as per the requirement.
- Related Buganizer: http://b/433251254
product-auto-label
bot
added
the
samples
glasnt
reviewed
Jul 27, 2025
Comment on lines
-24
to
+41
| bundle config set --local deployment 'true' && \ | ||
| bundle config set --local without 'development test' && \ | ||
| bundle install | ||
| bundle config set --local deployment 'true' && \ | ||
| bundle config set --local without 'development test' && \ | ||
| bundle install |
There was a problem hiding this comment.
nit: It's useful when using command continuations to use indenting to make it clear that this is all one layer, one run command.
Please apply to other commands.
| echo "deb [signed-by=/usr/share/keyrings/nodesource.gpg] https://deb.nodesource.com/node_20.x buster main" > \ | ||
| /etc/apt/sources.list.d/nodesource.list && \ | ||
| apt-get update && \ | ||
| apt-get install -y nodejs lsb-release |
There was a problem hiding this comment.
nit: it would make more sense to install the lsb-release package in the same step that the repository is setup
| # [START cloudrun_rails_base_image] | ||
| # Pinning the OS to buster because the nodejs install script is buster-specific. | ||
| # Be sure to update the nodejs install command if the base image OS is updated. | ||
| FROM ruby:3.2-buster |
There was a problem hiding this comment.
question: if there's an issue with buster, why not update the base image to bookworm? Does that version have the same issue?
glasnt
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.