Skip to content

chore(gmpctl): remove install of bingo deps #1963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bernot-dev wants to merge 1 commit into from
Closed

chore(gmpctl): remove install of bingo deps #1963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .conform.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ policies:
- deps
- e2e
- export
- gmpctl
- main
- operator
- prometheus
Expand Down
12 changes: 1 addition & 11 deletions ops/gmpctl/lib.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,17 +442,7 @@ release-lib::manifests_regen() {
return 1
fi

# TODO(bwplotka): Manage deps better. It's getting confusing what bins we should use (worktree bingo? script bingo?).
go install helm.sh/helm/v3/cmd/helm@latest
go install github.com/google/addlicense@latest
go install github.com/mikefarah/yq/v4@latest

# Hack: Do the bingo variable swap. This allows injecting our own.
# This is faster than running requiring bingo and running bingo get.
cp "${dir}/.bingo/variables.env" "${dir}/.bingo/variables.env.bak"
echo "#!/bin/bash" >"${dir}/.bingo/variables.env" # Clean the file.
YQ="$(which yq)" HELM="$(which helm)" ADDLICENSE="$(which addlicense)" bash "${dir}/hack/presubmit.sh" manifests
cp "${dir}/.bingo/variables.env.bak" "${dir}/.bingo/variables.env"
bash "${dir}/hack/presubmit.sh" manifests

@bwplotka bwplotka Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this won't work across all versions - it only makes it work for 0.19/main.

This could make it work for now: https://github.com/GoogleCloudPlatform/prometheus-engine/pull/1938/changes#r3441808186


echo "✅ Manifests regenerated"
return 0
Expand Down
Loading