Skip to content

fix: fix release/0.18 vulnerabilities - #1943

Merged
bernot-dev merged 1 commit into
release/0.18from
bwplotka/release/0.18-gmpctl-vulnfix
Jun 3, 2026
Merged

fix: fix release/0.18 vulnerabilities#1943
bernot-dev merged 1 commit into
release/0.18from
bwplotka/release/0.18-gmpctl-vulnfix

Conversation

@bwplotka

@bwplotka bwplotka commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Updating Go and image vulnerabilities using

./gmpctl.sh vulnfix

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Go builder image to version 1.26.4 and bumps the GKE distroless base images to version gke_distroless_20260601.00_p0 across several Dockerfiles and Helm values. Feedback on the changes suggests wrapping the updated bash image tag in double quotes within the Helm values file to ensure it is not incorrectly parsed as a number, adhering to the file's documented guidelines.

Comment thread charts/values.global.yaml
@bwplotka

bwplotka commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator Author

govulncheck seems to fail because Go action has an old Go version (actions/setup-go@v5.0.0)

@bwplotka
bwplotka force-pushed the bwplotka/release/0.18-gmpctl-vulnfix branch from 7616a6f to 27e4581 Compare June 3, 2026 13:58
Comment thread manifests/setup.yaml
@bwplotka
bwplotka force-pushed the bwplotka/release/0.18-gmpctl-vulnfix branch from 27e4581 to 3863dea Compare June 3, 2026 14:10
@bernot-dev

Copy link
Copy Markdown
Collaborator

Looks like the manifests are out of sync, need to be regenerated.

@bwplotka
bwplotka force-pushed the bwplotka/release/0.18-gmpctl-vulnfix branch from 3863dea to e30188e Compare June 3, 2026 15:08
@bwplotka

bwplotka commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator Author

done @bernot-dev

@bernot-dev bernot-dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: bwplotka <bwplotka@gmail.com>
@bernot-dev
bernot-dev force-pushed the bwplotka/release/0.18-gmpctl-vulnfix branch from e30188e to 2653abb Compare June 3, 2026 20:21
@bernot-dev
bernot-dev enabled auto-merge (rebase) June 3, 2026 20:23
@bernot-dev
bernot-dev merged commit cf8f659 into release/0.18 Jun 3, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants