Skip to content

Conversation

@melinath
Copy link
Member

@melinath melinath commented Jan 12, 2026

Fixes b/474729931. Prior to #16102 this wasn't causing problems because the test would only fail if there were values returned as "unknown" from the cache - but if the cache couldn't be loaded at all we would instead return "failed_to_populate_metadata_cache".

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@melinath melinath requested a review from ScottSuarez January 12, 2026 20:08
@melinath
Copy link
Member Author

attn @zli82016 as well since this changes logic related to TGC.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 32 insertions(+), 21 deletions(-))
google-beta provider: Diff ( 1 file changed, 32 insertions(+), 22 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 5911
Passed tests: 5276
Skipped tests: 633
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__service_perimeter_dry_run_egress_policy
  • TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🟢 All tests passed!

View the build log or the debug log for each test

@melinath melinath added this pull request to the merge queue Jan 12, 2026
@melinath
Copy link
Member Author

VCR failure is unrelated

Merged via the queue into GoogleCloudPlatform:main with commit 1c267b0 Jan 12, 2026
25 of 26 checks passed
@melinath melinath deleted the b-474729931 branch January 12, 2026 23:34
Gvantsats pushed a commit to Gvantsats/magic-modules that referenced this pull request Jan 13, 2026
amukul-25 pushed a commit to amukul-25/magic-modules that referenced this pull request Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants