-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Made meta.yaml test find services directory without hard-coded providerName #16117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
attn @zli82016 as well since this changes logic related to TGC. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 5911 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🟢 All tests passed! |
|
VCR failure is unrelated |
1c267b0
Fixes b/474729931. Prior to #16102 this wasn't causing problems because the test would only fail if there were values returned as
"unknown"from the cache - but if the cache couldn't be loaded at all we would instead return"failed_to_populate_metadata_cache".Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.