Skip to content

Conversation

@LucaPrete
Copy link
Member

@LucaPrete LucaPrete commented Jan 10, 2026

Adds PSC-I support to google_vertex_ai_reasoning_engine.

Opened hashicorp/terraform-provider-google/issues/25637 and referenced in code to keep track of current limitation due to internal bug.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

vertex_ai: added `deployment_spec.psc_interface_config` to `google_vertex_ai_reasoning_engine`

@github-actions github-actions bot requested a review from hao-nan-li January 10, 2026 09:27
@github-actions
Copy link

github-actions bot commented Jan 10, 2026

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 348 insertions(+))
google-beta provider: Diff ( 3 files changed, 348 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 91 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_reasoning_engine (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_reasoning_engine" "primary" {
  spec {
    deployment_spec {
      psc_interface_config {
        dns_peering_configs {
          domain         = # value needed
          target_network = # value needed
          target_project = # value needed
        }
        network_attachment = # value needed
      }
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 83
Passed tests: 80
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages
  • vertexai

🟢 All tests passed!

View the build log

@LucaPrete
Copy link
Member Author

@modular-magician reassign-reviewer rileykarson

@hao-nan-li
Copy link
Contributor

@modular-magician reassign-reviewer rileykarson

Are you looking to re-assign it to Riley?

@github-actions github-actions bot requested review from rileykarson and removed request for hao-nan-li January 12, 2026 17:48
@LucaPrete
Copy link
Member Author

LucaPrete commented Jan 12, 2026 via email

@zli82016
Copy link
Member

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 348 insertions(+))
google-beta provider: Diff ( 3 files changed, 348 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 91 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_reasoning_engine (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_reasoning_engine" "primary" {
  spec {
    deployment_spec {
      psc_interface_config {
        dns_peering_configs {
          domain         = # value needed
          target_network = # value needed
          target_project = # value needed
        }
        network_attachment = # value needed
      }
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 83
Passed tests: 80
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages
  • vertexai

🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants