Skip to content

Conversation

@zli82016
Copy link
Member

@zli82016 zli82016 commented Jan 8, 2026

Add the unique prefix to folders to make it easy check which tests have the leaked folders resources.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 25 insertions(+), 25 deletions(-))
google-beta provider: Diff ( 18 files changed, 31 insertions(+), 31 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1627
Passed tests: 1486
Skipped tests: 124
Affected tests: 17

Click here to see the affected service packages
  • compute
  • iam3
  • kms
  • logging
  • resourcemanager
  • resourcemanager3
  • accessapproval

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessApprovalSettings
  • TestAccComputeFirewallPolicyAssociation_organization
  • TestAccDataSourceAccessApprovalFolderServiceAccount_basic
  • TestAccFolderServiceIdentity_basic
  • TestAccIAM3FoldersPolicyBinding_iamFoldersPolicyBindingExample_update
  • TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample
  • TestAccKMSKeyHandle_kmsKeyHandleBasicExample
  • TestAccLoggingFolderSink_basic
  • TestAccLoggingFolderSink_described
  • TestAccLoggingFolderSink_disabled
  • TestAccLoggingFolderSink_folderAcceptsFullFolderPath
  • TestAccLoggingFolderSink_heredoc
  • TestAccLoggingFolderSink_removeOptionals
  • TestAccLoggingFolderSink_update
  • TestAccLoggingFolderSink_updateBigquerySink
  • TestAccResourceManager3Capability_resourceManagerCapabilityExample
  • TestAccResourceManagerCapability_resourceManagerCapabilityExample_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAccessApprovalSettings__organization [Debug log]
TestAccAccessApprovalSettings__project [Debug log]
TestAccFolderServiceIdentity_basic [Debug log]
TestAccIAM3FoldersPolicyBinding_iamFoldersPolicyBindingExample_update [Debug log]
TestAccKMSKeyHandle_kmsKeyHandleBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccAccessApprovalSettings__folder [Error message] [Debug log]
TestAccComputeFirewallPolicyAssociation_organization [Error message] [Debug log]
TestAccDataSourceAccessApprovalFolderServiceAccount_basic [Error message] [Debug log]
TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample [Error message] [Debug log]
TestAccLoggingFolderSink_basic [Error message] [Debug log]
TestAccLoggingFolderSink_described [Error message] [Debug log]
TestAccLoggingFolderSink_disabled [Error message] [Debug log]
TestAccLoggingFolderSink_folderAcceptsFullFolderPath [Error message] [Debug log]
TestAccLoggingFolderSink_heredoc [Error message] [Debug log]
TestAccLoggingFolderSink_removeOptionals [Error message] [Debug log]
TestAccLoggingFolderSink_update [Error message] [Debug log]
TestAccLoggingFolderSink_updateBigquerySink [Error message] [Debug log]
TestAccResourceManager3Capability_resourceManagerCapabilityExample [Error message] [Debug log]
TestAccResourceManagerCapability_resourceManagerCapabilityExample_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 27 insertions(+), 27 deletions(-))
google-beta provider: Diff ( 18 files changed, 33 insertions(+), 33 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1626
Passed tests: 1484
Skipped tests: 124
Affected tests: 18

Click here to see the affected service packages
  • iam3
  • kms
  • logging
  • resourcemanager
  • resourcemanager3
  • accessapproval
  • compute

Action taken

Found 18 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessApprovalSettings
  • TestAccComputeFirewallPolicyAssociation_basic
  • TestAccComputeFirewallPolicyAssociation_organization
  • TestAccComputeFirewallPolicyAssociation_swapover
  • TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update
  • TestAccDataSourceAccessApprovalFolderServiceAccount_basic
  • TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample
  • TestAccKMSKeyHandle_kmsKeyHandleBasicExample
  • TestAccLoggingFolderSink_basic
  • TestAccLoggingFolderSink_described
  • TestAccLoggingFolderSink_disabled
  • TestAccLoggingFolderSink_folderAcceptsFullFolderPath
  • TestAccLoggingFolderSink_heredoc
  • TestAccLoggingFolderSink_removeOptionals
  • TestAccLoggingFolderSink_update
  • TestAccLoggingFolderSink_updateBigquerySink
  • TestAccResourceManager3Capability_resourceManagerCapabilityExample
  • TestAccResourceManagerCapability_resourceManagerCapabilityExample_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAccessApprovalSettings__organization [Debug log]
TestAccAccessApprovalSettings__project [Debug log]
TestAccComputeFirewallPolicyAssociation_basic [Debug log]
TestAccComputeFirewallPolicyAssociation_organization [Debug log]
TestAccComputeFirewallPolicyAssociation_swapover [Debug log]
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Debug log]
TestAccDataSourceAccessApprovalFolderServiceAccount_basic [Debug log]
TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample [Debug log]
TestAccKMSKeyHandle_kmsKeyHandleBasicExample [Debug log]
TestAccLoggingFolderSink_basic [Debug log]
TestAccLoggingFolderSink_described [Debug log]
TestAccLoggingFolderSink_disabled [Debug log]
TestAccLoggingFolderSink_folderAcceptsFullFolderPath [Debug log]
TestAccLoggingFolderSink_heredoc [Debug log]
TestAccLoggingFolderSink_removeOptionals [Debug log]
TestAccLoggingFolderSink_update [Debug log]
TestAccLoggingFolderSink_updateBigquerySink [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccAccessApprovalSettings__folder [Error message] [Debug log]
TestAccResourceManager3Capability_resourceManagerCapabilityExample [Error message] [Debug log]
TestAccResourceManagerCapability_resourceManagerCapabilityExample_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 51 insertions(+), 130 deletions(-))
google-beta provider: Diff ( 19 files changed, 57 insertions(+), 136 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1626
Passed tests: 1499
Skipped tests: 124
Affected tests: 3

Click here to see the affected service packages
  • kms
  • logging
  • resourcemanager
  • resourcemanager3
  • accessapproval
  • compute
  • iam3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessApprovalSettings
  • TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update
  • TestAccResourceManagerCapability_resourceManagerCapabilityExample_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAccessApprovalSettings__folder [Debug log]
TestAccAccessApprovalSettings__project [Debug log]
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccAccessApprovalSettings__organization [Error message] [Debug log]
TestAccResourceManagerCapability_resourceManagerCapabilityExample_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 52 insertions(+), 130 deletions(-))
google-beta provider: Diff ( 19 files changed, 58 insertions(+), 136 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1626
Passed tests: 1501
Skipped tests: 124
Affected tests: 1

Click here to see the affected service packages
  • kms
  • logging
  • resourcemanager
  • resourcemanager3
  • accessapproval
  • compute
  • iam3

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccResourceManagerCapability_resourceManagerCapabilityExample_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccResourceManagerCapability_resourceManagerCapabilityExample_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 29 insertions(+), 130 deletions(-))
google-beta provider: Diff ( 19 files changed, 35 insertions(+), 136 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1628
Passed tests: 1503
Skipped tests: 124
Affected tests: 1

Click here to see the affected service packages
  • accessapproval
  • compute
  • iam3
  • kms
  • logging
  • resourcemanager
  • resourcemanager3

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccResourceManagerCapability_resourceManagerCapabilityExample_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccResourceManagerCapability_resourceManagerCapabilityExample_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@zli82016 zli82016 marked this pull request as ready for review January 9, 2026 01:39
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 31 insertions(+), 130 deletions(-))
google-beta provider: Diff ( 19 files changed, 37 insertions(+), 136 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1628
Passed tests: 1503
Skipped tests: 125
Affected tests: 0

Click here to see the affected service packages
  • kms
  • logging
  • resourcemanager
  • resourcemanager3
  • accessapproval
  • compute
  • iam3

🟢 All tests passed!

View the build log

@zli82016 zli82016 requested a review from shuyama1 January 9, 2026 16:06
Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@zli82016 zli82016 added this pull request to the merge queue Jan 9, 2026
Merged via the queue into GoogleCloudPlatform:main with commit ccf972c Jan 9, 2026
26 checks passed
@zli82016 zli82016 deleted the folder-prefix branch January 9, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants