Sync main jan 7 feature branch resource identity #16097
Conversation
…et for spanner instances (GoogleCloudPlatform#15919)
…5306) Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
…#15933) Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
…latform#15861) Co-authored-by: Marek Lipert <[email protected]>
…#15930) Signed-off-by: Julia Zou <[email protected]>
…to prevent Terraform from managing the settings.0.backup_configuration block when an instance is managed by GCBDR. (GoogleCloudPlatform#15710) Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
…tform#14956) Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
…dPlatform#16074) Co-authored-by: trollyxia <[email protected]>
…tform#16024) Co-authored-by: sushilchaskar <[email protected]>
…gleCloudPlatform#15828) Co-authored-by: Nick Elliot <[email protected]>
Co-authored-by: Zhenhua Li <[email protected]>
modular-magician
added
the
awaiting-approval
…FEATURE-BRANCH-resource-identity
modular-magician
added
service/terraform
and removed
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_alloydb_instance" "primary" {
observability_config {
track_wait_event_types = # value needed
}
}
Resource: resource "google_biglake_iceberg_catalog_iam_binding" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
Resource: resource "google_biglake_iceberg_catalog_iam_member" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
Resource: resource "google_cloud_run_v2_worker_pool" "primary" {
custom_audiences = # value needed
}
Resource: resource "google_compute_region_commitment" "primary" {
type = # value needed
}
Resource: resource "google_container_cluster" "primary" {
node_pool_defaults {
node_config_defaults {
containerd_config {
registry_hosts {
hosts {
client {
cert {
gcp_secret_manager_secret_uri = # value needed
}
key {
gcp_secret_manager_secret_uri = # value needed
}
}
}
}
}
}
}
}
Resource: resource "google_datastream_connection_profile" "primary" {
postgresql_profile {
ssl_config {
server_verification {
ca_certificate = # value needed
}
}
}
}
Resource: resource "google_datastream_stream" "primary" {
rule_sets {
customization_rules {
bigquery_clustering {
columns = # value needed
}
bigquery_partitioning {
ingestion_time_partition {
partitioning_time_granularity = # value needed
}
integer_range_partition {
column = # value needed
end = # value needed
interval = # value needed
start = # value needed
}
require_partition_filter = # value needed
time_unit_partition {
column = # value needed
partitioning_time_granularity = # value needed
}
}
}
object_filter {
source_object_identifier {
mongodb_identifier {
collection = # value needed
database = # value needed
}
mysql_identifier {
database = # value needed
table = # value needed
}
oracle_identifier {
schema = # value needed
table = # value needed
}
postgresql_identifier {
schema = # value needed
table = # value needed
}
salesforce_identifier {
object_name = # value needed
}
sql_server_identifier {
schema = # value needed
table = # value needed
}
}
}
}
}
Resource: resource "google_netapp_volume" "primary" {
hybrid_replication_parameters {
cluster_location = # value needed
hybrid_replication_type = # value needed
large_volume_constituent_count = # value needed
peer_cluster_name = # value needed
peer_ip_addresses = # value needed
peer_svm_name = # value needed
peer_volume_name = # value needed
}
}
Resource: resource "google_sql_database_instance" "primary" {
replication_cluster {
psa_write_endpoint = # value needed
}
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Multiple resources addedThis PR adds multiple new resources: Missing doc report (experimental)The following resources have fields missing in documents.
The following data sources are missing documents:
|
Non-exercised tests🔴 Tests were added that are skipped in VCR:
🔴 Tests were added that are GA-only additions and require manual runs:
Tests analyticsTotal tests: 3957 Click here to see the affected service packages
Action takenFound 160 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🔴 Tests failed during RECORDING mode: 🔴 Several tests terminated during RECORDING mode. 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
20 participants
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.