Add NFS Datastore resource in vmwareengine service

mmv1/products/vmwareengine/Datastore.yaml

@@ -0,0 +1,179 @@
+# Copyright 2024 Google Inc.
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+---
+name: Datastore
+description: A datastore resource that can be mounted on a privatecloud cluster
+base_url: projects/{{project}}/locations/{{location}}/datastores
+update_mask: true
+self_link: projects/{{project}}/locations/{{location}}/datastores/{{name}}
+create_url: projects/{{project}}/locations/{{location}}/datastores?datastoreId={{name}}
+update_verb: PATCH
+id_format: projects/{{project}}/locations/{{location}}/datastores/{{name}}
+import_format:
+  - projects/{{project}}/locations/{{location}}/datastores/{{name}}
+examples:
+  - name: vmware_engine_datastore_thirdparty
+    config_path: "examples/vmware_engine_datastore_thirdparty.tf.tmpl"
+    primary_resource_id: example_thirdparty
+    vars:
+      resource_name: thirdparty-datastore
+    test_env_vars:
+      region: "REGION"
+      project: "PROJECT"
+    # Update tests take care of both create and update - Datastore deletion requires some additional setup
+    exclude_test: true
+  - name: vmware_engine_datastore_filestore
+    config_path: "examples/vmware_engine_datastore_filestore.tf.tmpl"
+    primary_resource_id: example_filestore
+    vars:
+      resource_name: filestore-datastore
+      network_name: default
+    test_env_vars:
+      region: "REGION"
+      zone: "ZONE"
+      project: "PROJECT"
+    # Update tests take care of both create and update - Datastore deletion requires some additional setup
+    exclude_test: true
+  - name: vmware_engine_datastore_netapp
+    config_path: "examples/vmware_engine_datastore_netapp.tf.tmpl"
+    primary_resource_id: example_netapp
+    vars:
+      resource_name: netapp-datastore
+      network_name: default
+    test_env_vars:
+      region: "REGION"
+      project: "PROJECT"
+    # Update tests take care of both create and update - Datastore deletion requires some additional setup
+    exclude_test: true
+autogen_async: true
+async:
+  operation:
+    timeouts:
+      insert_minutes: 20
+      update_minutes: 20
+      delete_minutes: 20
+    base_url: "{{op_id}}"
+  actions:
+    - create
+    - delete
+    - update
+  type: OpAsync
+  result:
+    resource_inside_response: true
+  include_project: false
+autogen_status: RGF0YXN0b3Jl
+parameters:
+  - name: location
+    type: String
+    description: Resource ID segment making up resource `name`. It identifies the resource within its parent collection as described in https://google.aip.dev/122.
+    immutable: true
+    url_param_only: true
+    required: true
+  - name: name
+    type: String
+    description: |-
+      The user-provided identifier of the datastore to be created.
+      This identifier must be unique among each `Datastore` within the parent
+      and becomes the final token in the name URI.
+      The identifier must meet the following requirements:
+
+      * Only contains 1-63 alphanumeric characters and hyphens
+      * Begins with an alphabetical character
+      * Ends with a non-hyphen character
+      * Not formatted as a UUID
+      * Complies with [RFC 1034](https://datatracker.ietf.org/doc/html/rfc1034)
+      (section 3.5)
+    immutable: true
+    url_param_only: true
+    required: true
+properties:
+  - name: clusters
+    type: Array
+    description: Clusters to which the datastore is attached.
+    output: true
+    item_type:
+      type: String
+  - name: createTime
+    type: String
+    description: Creation time of this resource.
+    output: true
+  - name: description
+    type: String
+    description: User-provided description for this datastore
+  - name: nfsDatastore
+    type: NestedObject
+    description: The NFS datastore configuration.
+    required: true
+    properties:
+      - name: googleFileService
+        type: NestedObject
+        description: Google service file service configuration
+        properties:
+          - name: filestoreInstance
+            type: String
+            description: |-
+              Google filestore instance resource name
+              e.g. projects/my-project/locations/me-west1-b/instances/my-instance
+          - name: netappVolume
+            type: String
+            description: |-
+              Google netapp volume resource name
+              e.g. projects/my-project/locations/me-west1-b/volumes/my-volume
+      - name: thirdPartyFileService
+        type: NestedObject
+        description: Third party file service configuration
+        properties:
+          - name: fileShare
+            type: String
+            description: |-
+              Required
+              Mount Folder name
+            required: true
+          - name: network
+            type: String
+            description: |-
+              Required to identify vpc peering used for NFS access
+              network name of NFS's vpc
+              e.g. projects/project-id/global/networks/my-network_id
+            required: true
+          - name: servers
+            type: Array
+            description: |-
+              Server IP addresses of the NFS file service.
+              NFS v3, provide a single IP address or DNS name.
+              Multiple servers can be supported in future when NFS 4.1 protocol support
+              is enabled.
+            required: true
+            item_type:
+              type: String
+  - name: state
+    type: String
+    description: |-
+      The state of the Datastore.
+      Possible values:
+      CREATING
+      ACTIVE
+      UPDATING
+      DELETING
+      SOFT_DELETING
+      SOFT_DELETED
+    output: true
+  - name: uid
+    type: String
+    description: System-generated unique identifier for the resource.
+    output: true
+  - name: updateTime
+    type: String
+    description: Last update time of this resource.
+    output: true

mmv1/templates/terraform/examples/vmware_engine_datastore_filestore.tf.tmpl

@@ -0,0 +1,18 @@
+# Use existing filestore instance
+data "google_filestore_instance" "test_instance" {
+  name     = "tf-test-datastore-fs-instance"
+  location = "{{index $.TestEnvVars "zone"}}"
+}
+
+# Create a VmwareEngine Datastore, referencing the filestore instance
+resource "google_vmwareengine_datastore" "{{$.PrimaryResourceId}}" {
+  name        = "{{index $.Vars "resource_name"}}"
+  location    = "{{index $.TestEnvVars "zone"}}"
+  description = "example google_file_service.filestore datastore."
+
+  nfs_datastore {
+    google_file_service {
+      filestore_instance = google_filestore_instance.test_instance.id
+    }
+  }
+}

mmv1/templates/terraform/examples/vmware_engine_datastore_netapp.tf.tmpl

@@ -0,0 +1,18 @@
+# Use existing netapp volume
+resource "google_netapp_volume" "test_volume" {
+  name     = "netapp-volume"
+  location = "{{index $.TestEnvVars "region"}}"
+}
+
+# Create a VmwareEngine Datastore, referencing the netapp volume
+resource "google_vmwareengine_datastore" "{{$.PrimaryResourceId}}" {
+  name        = "{{index $.Vars "resource_name"}}"
+  location    = "{{index $.TestEnvVars "region"}}"
+  description = "example google_file_service.netapp datastore."
+
+  nfs_datastore {
+    google_file_service {
+      netapp_volume = google_netapp_volume.test_volume.id
+    }
+  }
+}

mmv1/templates/terraform/examples/vmware_engine_datastore_thirdparty.tf.tmpl

@@ -0,0 +1,19 @@
+# use existing network with connectivity to the thirdparty datastore
+data "google_compute_network" "default" {
+  name      = "default"
+}
+
+# create a thirdparty datastore
+resource "google_vmwareengine_datastore" "{{$.PrimaryResourceId}}" {
+  name        = "{{index $.Vars "resource_name"}}"
+  location    = "{{index $.TestEnvVars "region"}}-a"
+  description = "example thirdparty datastore."
+
+  nfs_datastore {
+    third_party_file_service {
+      file_share  = "/share1"
+      network     = data.google_compute_network.default.id
+      servers     = ["10.0.0.4"]
+    }
+  }
+}

mmv1/third_party/terraform/provider/provider_mmv1_resources.go.tmpl

@@ -308,6 +308,7 @@ var handwrittenDatasources = map[string]*schema.Resource{
 	"google_vmwareengine_private_cloud":                vmwareengine.DataSourceVmwareenginePrivateCloud(),
 	"google_vmwareengine_subnet":                       vmwareengine.DataSourceVmwareengineSubnet(),
 	"google_vmwareengine_vcenter_credentials":          vmwareengine.DataSourceVmwareengineVcenterCredentials(),
+	"google_vmwareengine_datastore":                    vmwareengine.DataSourceVmwareengineDatastore(),
 	"google_compute_region_backend_service":            compute.DataSourceGoogleComputeRegionBackendService(),
 	"google_network_management_connectivity_test_run":  networkmanagement.DataSourceGoogleNetworkManagementTestRun(),
 	"google_network_management_connectivity_tests":  	networkmanagement.DataSourceGoogleNetworkManagementConnectivityTests(),

mmv1/third_party/terraform/services/vmwareengine/data_source_google_vmwareengine_datastore.go

@@ -0,0 +1,40 @@
+package vmwareengine
+
+import (
+	"fmt"
+
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+	"github.com/hashicorp/terraform-provider-google/google/tpgresource"
+	transport_tpg "github.com/hashicorp/terraform-provider-google/google/transport"
+)
+
+func DataSourceVmwareengineDatastore() *schema.Resource {
+
+	dsSchema := tpgresource.DatasourceSchemaFromResourceSchema(ResourceVmwareengineDatastore().Schema)
+	tpgresource.AddRequiredFieldsToSchema(dsSchema, "name", "location")
+	tpgresource.AddOptionalFieldsToSchema(dsSchema, "project")
+	return &schema.Resource{
+		Read:   dataSourceVmwareengineDatastoreRead,
+		Schema: dsSchema,
+	}
+}
+
+func dataSourceVmwareengineDatastoreRead(d *schema.ResourceData, meta interface{}) error {
+	config := meta.(*transport_tpg.Config)
+
+	// Store the ID now
+	id, err := tpgresource.ReplaceVars(d, config, "projects/{{project}}/locations/{{location}}/datastores/{{name}}")
+	if err != nil {
+		return fmt.Errorf("Error constructing id: %s", err)
+	}
+	d.SetId(id)
+	err = resourceVmwareengineDatastoreRead(d, meta)
+	if err != nil {
+		return err
+	}
+
+	if d.Id() == "" {
+		return fmt.Errorf("%s not found", id)
+	}
+	return nil
+}