Skip to content

Conversation

@Kartikeyapise
Copy link
Member

@Kartikeyapise Kartikeyapise commented Jan 5, 2026

kms: added `key_project_resolution_mode` field and project-level support to `google_kms_autokey_config` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 5, 2026
@github-actions github-actions bot requested a review from shuyama1 January 5, 2026 14:29
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code generator was migrated from Ruby to Go.

Could you please update the code in this PR to align with the current Go-based implementation?

https://googlecloudplatform.github.io/magic-modules/reference/ruby-go-changes/
https://googlecloudplatform.github.io/magic-modules/develop/add-resource/

@Kartikeyapise Kartikeyapise force-pushed the autokey-project-support branch from e3894b9 to b37cd93 Compare January 6, 2026 10:07
@github-actions github-actions bot requested a review from shuyama1 January 6, 2026 10:08
@Kartikeyapise
Copy link
Member Author

The code generator was migrated from Ruby to Go.

Could you please update the code in this PR to align with the current Go-based implementation?

https://googlecloudplatform.github.io/magic-modules/reference/ruby-go-changes/ https://googlecloudplatform.github.io/magic-modules/develop/add-resource/

Have migrated to go @shuyama1

@github-actions
Copy link

github-actions bot commented Jan 9, 2026

@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician added service/cloudkms and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 9, 2026
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 931 insertions(+), 155 deletions(-))
google-beta provider: Diff ( 8 files changed, 1020 insertions(+), 223 deletions(-))
terraform-google-conversion: Diff ( 8 files changed, 208 insertions(+), 368 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_kms_autokey_config (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_kms_autokey_config" "primary" {
  key_project_resolution_mode = # value needed
}

Resource: google_kms_google_kms_autokey_config (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_kms_google_kms_autokey_config" "primary" {
  folder = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 50
Passed tests: 40
Skipped tests: 6
Affected tests: 4

Click here to see the affected service packages
  • kms

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGoogleKmsAutokeyConfig_basic
  • TestAccKMSAutokeyConfig_kmsAutokeyConfigFolderExample
  • TestAccKMSAutokeyConfig_kmsAutokeyConfigProjectExample
  • TestAccKMSKeyHandle_kmsKeyHandleBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleKmsAutokeyConfig_basic [Error message] [Debug log]
TestAccKMSAutokeyConfig_kmsAutokeyConfigFolderExample [Error message] [Debug log]
TestAccKMSAutokeyConfig_kmsAutokeyConfigProjectExample [Error message] [Debug log]
TestAccKMSKeyHandle_kmsKeyHandleBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@Kartikeyapise Kartikeyapise force-pushed the autokey-project-support branch from e8f3efd to e769021 Compare January 12, 2026 12:36
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 12, 2026
@Kartikeyapise Kartikeyapise force-pushed the autokey-project-support branch 2 times, most recently from 9bbb447 to e517c6c Compare January 12, 2026 13:05
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 12, 2026
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 403 insertions(+), 152 deletions(-))
google-beta provider: Diff ( 4 files changed, 475 insertions(+), 220 deletions(-))
terraform-google-conversion: Diff ( 7 files changed, 96 insertions(+), 368 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_kms_autokey_config (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_kms_autokey_config" "primary" {
  key_project_resolution_mode = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 50
Passed tests: 40
Skipped tests: 6
Affected tests: 4

Click here to see the affected service packages
  • kms

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGoogleKmsAutokeyConfig_basic
  • TestAccKMSAutokeyConfig_kmsAutokeyConfigFolderExample
  • TestAccKMSAutokeyConfig_kmsAutokeyConfigProjectExample
  • TestAccKMSKeyHandle_kmsKeyHandleBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleKmsAutokeyConfig_basic [Error message] [Debug log]
TestAccKMSAutokeyConfig_kmsAutokeyConfigFolderExample [Error message] [Debug log]
TestAccKMSAutokeyConfig_kmsAutokeyConfigProjectExample [Error message] [Debug log]
TestAccKMSKeyHandle_kmsKeyHandleBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants