Skip to content

Conversation

@shuyama1
Copy link
Member

@shuyama1 shuyama1 commented Jan 2, 2026

SQL operations occasionally return transient internal errors while in the RUNNING state (the backend automatically retries those errors internally). This PR ensures we don't error out prematurely when the operation is still in progress and likely to succeed.

More context: b/457257721

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

sql: fixed an issue where transient server errors caused false failures for SQL operations that eventually completed successfully

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@shuyama1
Copy link
Member Author

shuyama1 commented Jan 2, 2026

TC link

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 137
Passed tests: 110
Skipped tests: 26
Affected tests: 1

Click here to see the affected service packages
  • sql

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSqlDatabaseInstance_activationPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccSqlDatabaseInstance_activationPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 137
Passed tests: 110
Skipped tests: 27
Affected tests: 0

Click here to see the affected service packages
  • sql

🟢 All tests passed!

View the build log

@shuyama1 shuyama1 changed the title [Do Not Merge] Ensure SQL operations complete before reporting errors Ensure SQL operations complete before reporting errors Jan 9, 2026
@shuyama1 shuyama1 requested a review from zli82016 January 10, 2026 00:11
@shuyama1 shuyama1 added this pull request to the merge queue Jan 10, 2026
Merged via the queue into main with commit d2ee9cb Jan 10, 2026
28 of 29 checks passed
@shuyama1 shuyama1 deleted the shuyama1-patch-37 branch January 10, 2026 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants