Skip to content

Conversation

@mysterytony
Copy link
Contributor

@mysterytony mysterytony commented Sep 12, 2025

Description

cloudrunci updates to support readiness probe additions in #5368

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 12, 2025
@mysterytony mysterytony force-pushed the cloudrunci_readinessprobe branch from b3b6abc to 885968c Compare September 12, 2025 18:29
@mysterytony mysterytony marked this pull request as ready for review September 12, 2025 18:35
@mysterytony mysterytony requested review from a team as code owners September 12, 2025 18:35
@mysterytony mysterytony force-pushed the cloudrunci_readinessprobe branch from 885968c to efb224c Compare September 12, 2025 18:45
@iennae
Copy link
Contributor

iennae commented Sep 19, 2025

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for readiness probes to Cloud Run services. The implementation is mostly correct, but there are a few areas for improvement. I've identified an issue with how the readiness probe arguments are constructed, which could lead to invalid commands being generated. I've also suggested a refactoring to use named structs for the probe configuration to improve code clarity and maintainability, which would also simplify the new tests.

@mysterytony mysterytony force-pushed the cloudrunci_readinessprobe branch from 24b13bc to 9fdf6ac Compare September 24, 2025 20:16
@mysterytony mysterytony force-pushed the cloudrunci_readinessprobe branch from 9fdf6ac to 6504389 Compare September 24, 2025 20:17
@mysterytony
Copy link
Contributor Author

Hi! Thanks for the review, I've addressed the comments, please take another look.

@briandorsey briandorsey self-assigned this Sep 26, 2025
@briandorsey briandorsey added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 26, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 26, 2025
Copy link
Contributor

@briandorsey briandorsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for breaking out these CI support changes into a separate PR! Look good overall. I added one comment. Tested manually and tests pass.

Started an integration test run as well. Will merge after that assuming no Cloud Run related failures.

@briandorsey briandorsey merged commit 1ed9bcd into GoogleCloudPlatform:main Sep 27, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants