- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.8k
 
feat(cloudrun): allow adding new readiness probe to cloud run #5387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloudrun): allow adding new readiness probe to cloud run #5387
Conversation
b3b6abc    to
    885968c      
    Compare
  
    885968c    to
    efb224c      
    Compare
  
    | 
           /gemini review  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for readiness probes to Cloud Run services. The implementation is mostly correct, but there are a few areas for improvement. I've identified an issue with how the readiness probe arguments are constructed, which could lead to invalid commands being generated. I've also suggested a refactoring to use named structs for the probe configuration to improve code clarity and maintainability, which would also simplify the new tests.
24b13bc    to
    9fdf6ac      
    Compare
  
    9fdf6ac    to
    6504389      
    Compare
  
    | 
           Hi! Thanks for the review, I've addressed the comments, please take another look.  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for breaking out these CI support changes into a separate PR! Look good overall. I added one comment. Tested manually and tests pass.
Started an integration test run as well. Will merge after that assuming no Cloud Run related failures.
Description
cloudrunciupdates to support readiness probe additions in #5368Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
go test -v ./..(see Testing)gofmt(see Formatting)go vet(see Formatting)