Pushdown/join#210
Open
stevelordbq wants to merge 19 commits into
Open
Conversation
stevelordbq
marked this pull request as draft
July 9, 2026 16:03
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for logical query planning, expressions, and relations in the Spark Spanner connector to enable advanced pushdowns like joins. Feedback on these changes highlights several critical issues: potential ClassCastExceptions in SpannerTypeBinder due to incorrect JVM representation of DecimalType and in PredicateToExprConverter due to missing type checks on predicate children; a fail-fast violation in SpannerScanner that could defer NullPointerExceptions; type mapping inconsistencies in SpannerTypeBinder for short, byte, and float types; and a hardcoded if (true) condition in SpannerQueryBuilder that bypasses the new SQL generation path.
# Conflicts: # spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/planning/expression/AndExpr.java # spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/planning/expression/BoolExpr.java # spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/planning/expression/ColumnExpr.java # spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/planning/expression/ContainsExpr.java # spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/planning/expression/EndsWithExpr.java # spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/planning/expression/EqExpr.java # spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/planning/expression/EqNullSafeExpr.java # spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/planning/expression/GtExpr.java # spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/planning/expression/GteExpr.java # spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/planning/expression/InExpr.java # spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/planning/expression/IsNotNullExpr.java # spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/planning/expression/IsNullExpr.java # spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/planning/expression/LiteralExpr.java # spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/planning/expression/LtExpr.java # spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/planning/expression/LteExpr.java # spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/planning/expression/NotExpr.java # spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/planning/expression/OrExpr.java # spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/planning/expression/SpannerExpr.java # spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/planning/expression/SpannerExprVisitor.java # spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/planning/expression/StartsWithExpr.java # spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/planning/expression/TrueExpr.java # spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/planning/expression/ValueExpr.java # spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/planning/relation/JoinRelation.java # spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/planning/relation/JoinType.java # spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/planning/relation/Relation.java # spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/planning/relation/RelationVisitor.java # spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/planning/relation/TableRelation.java # spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/scan/SpannerScanner.java
# Conflicts: # spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/SparkSpannerTableProviderBase.java
stevelordbq
marked this pull request as ready for review
July 21, 2026 15:24
Collaborator
|
/gcbrun |
jiangzzhu
reviewed
Jul 21, 2026
jiangzzhu
reviewed
Jul 21, 2026
Collaborator
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.