-
Notifications
You must be signed in to change notification settings - Fork 23
Pom refactor - Add Spark 3.5 connector #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 26 commits
4d6c8cb
aeb248a
1b73333
cde85f2
ce92171
ada76f5
edc8bf5
99b14b7
9f03990
135a83a
a2fc9e4
f61bd66
5c0ec34
8b3bf44
780d367
0af1917
ca7830b
6be6bea
2ea346e
f0f84e4
88e20c4
2026367
5bc1d84
f5b2e51
19fd72c
36a0c40
7e5f033
28c371c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,14 +38,20 @@ If you run a Spark job on the Dataproc cluster, you'll have to assign correspond | |
| You can find the released jar file from the Releases tag on right of the github page. The name pattern is spark-3.1-spanner-x.x.x.jar. The 3.1 indicates the driver depends on the Spark 3.1 and x.x.x is the Spark Spanner connector version. The alternative way is to use `gs://spark-lib/spanner/spark-3.1-spanner-${next-release-tag}.jar` directly. | ||
|
|
||
| ### Connector to Spark Compatibility Matrix | ||
| | Connector \ Spark | 2.3 | 2.4<br>(Scala 2.11) | 2.4<br>(Scala 2.12) | 3.0 | 3.1 | 3.2 | 3.3 | 3.4 | 3.5 | | ||
| |---------------------------------------|---------|---------------------|---------------------|---------|---------|---------|---------|---------|---------| | ||
| | spark-3.1-spanner | | | | | ✓ | ✓ | ✓ | ✓ | ✓ | | ||
| | Connector \ Spark | 2.3 | 2.4<br>(Scala 2.11) | 2.4<br>(Scala 2.12) | 3.0 | 3.1 | 3.2 | 3.3 | 3.4 | 3.5 | | ||
| |-------------------|---------|---------------------|---------------------|---------|---------|---------|---------|---------|---------| | ||
| | spark-3.1-spanner | | | | | ✓ | ✓ | ✓ | ✓ | ✓ | | ||
| | spark-3.2-spanner | | | | | | ✓ | ✓ | ✓ | ✓ | | ||
| | spark-3.3-spanner | | | | | | | ✓ | ✓ | ✓ | | ||
| | spark-3.5-spanner | | | | | | | | | ✓ | | ||
|
|
||
| ### Connector to Dataproc Image Compatibility Matrix | ||
| | Connector \ Dataproc Image | 1.3 | 1.4 | 1.5 | 2.0 | 2.1 | 2.2 | Serverless<br>Image 1.0 | Serverless<br>Image 2.0 | Serverless<br>Image 2.1 | | ||
| |---------------------------------------|---------|---------|---------|---------|---------|---------|-------------------------|-------------------------|-------------------------| | ||
| | spark-3.1-spanner | | | | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | | ||
| | Connector \ Dataproc Image | 1.3 | 1.4 | 1.5 | 2.0 | 2.1 | 2.2 | Serverless<br>Image 1.1 | Serverless<br>Image 1.2 | Serverless<br>Image 2.0 | Serverless<br>Image 2.1 | Serverless<br>Image 2.2 | | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why does spark 3.1,3.2,3.3 not work with serverless 1.2 and 2.2?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We haven't tested that those combinations work. So it may work. Did you want us to increase the cross version compatibility testing?
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If adding the test is simple (by acceptance test), maybe we could add it, so we could check on those entries. |
||
| |----------------------------|---------|---------|---------|---------|---------|---------|-------------------------|-------------------------|-------------------------|-------------------------|-------------------------| | ||
| | spark-3.1-spanner | | | | ✓ | ✓ | ✓ | ✓ | | ✓ | ✓ | | | ||
| | spark-3.2-spanner | | | | ✓ | ✓ | ✓ | ✓ | | ✓ | ✓ | | | ||
| | spark-3.3-spanner | | | | ✓ | ✓ | ✓ | ✓ | | ✓ | ✓ | | | ||
| | spark-3.5-spanner | | | | | | ✓ | | ✓ | | | ✓ | | ||
|
|
||
| ### Maven / Ivy Package | ||
|
|
||
|
|
||
|
stevelordbq marked this conversation as resolved.
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project xmlns="http://maven.apache.org/POM/4.0.0" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
| <parent> | ||
| <groupId>com.google.cloud.spark.spanner</groupId> | ||
| <artifactId>spark-spanner-lib-parent</artifactId> | ||
| <version>${revision}</version> | ||
| <relativePath>../spark-spanner-lib-parent</relativePath> | ||
| </parent> | ||
|
|
||
| <artifactId>spanner-core</artifactId> | ||
| <name>Spanner core library</name> | ||
| <description>This module contains Spanner code and no Spark dependencies.</description> | ||
|
|
||
| <dependencies> | ||
| <dependency> | ||
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>google-cloud-spanner</artifactId> | ||
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>google-cloud-dataproc</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>google-cloud-storage</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>com.google.code.gson</groupId> | ||
| <artifactId>gson</artifactId> | ||
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>com.fasterxml.jackson.core</groupId> | ||
| <artifactId>jackson-databind</artifactId> | ||
| </dependency> | ||
| </dependencies> | ||
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-jar-plugin</artifactId> | ||
| <version>3.3.0</version> | ||
| <executions> | ||
| <execution> | ||
| <goals> | ||
| <goal>test-jar</goal> | ||
| </goals> | ||
| </execution> | ||
| </executions> | ||
| </plugin> | ||
| </plugins> | ||
| </build> | ||
|
|
||
| </project> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| connector.version=test |
Uh oh!
There was an error while loading. Please reload this page.