Skip to content

Conversation

nvliyuan
Copy link
Contributor

update spark-rapids init script for dataproc 3.0 images support.
Verified ubuntu2404 and debian12 image

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @nvliyuan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the spark-rapids.sh initialization script by extending its compatibility to newer environments. It introduces support for Dataproc 3.0 images, including Ubuntu 24.04 and Debian 12, with specialized handling for CUDA and NVIDIA driver installations on Ubuntu 24.04, particularly for systems running kernel 6.14+. Furthermore, the script is updated to fully support Spark 4.0 and its associated Scala 2.13 version, ensuring proper dependency resolution and configuration for the RAPIDS plugin.

Highlights

  • Dataproc 3.0 Image Support: The script now supports Dataproc 3.0 images, specifically Ubuntu 24.04 and Debian 12, expanding its compatibility to newer environments.
  • Ubuntu 24.04 CUDA/Driver Handling: Introduces specific logic for installing CUDA and NVIDIA drivers on Ubuntu 24.04, including repository-based installation for kernel 6.14+ to get the latest compatible drivers (570+).
  • Spark 4.0 and Scala 2.13 Support: The script now recognizes and configures for Spark 4.0, setting the Scala version to 2.13 for appropriate dependency resolution and plugin compatibility.
  • Dynamic Spark RAPIDS Jar Installation: The install_spark_rapids function has been updated to conditionally download the cuda12 variant of the rapids-4-spark jar for Spark 4.0, ensuring correct dependency fetching.
  • Enhanced GPU Exclusive Mode Configuration: The configure_gpu_exclusive_mode function now correctly applies to both Spark 3.x and 4.x environments, ensuring optimal GPU utilization.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Spark-RAPIDS initialization script to support Dataproc 3.0 images, which includes adding compatibility for Ubuntu 24.04 and Spark 4.0. The changes are generally well-structured, but there are a few areas that need attention. A potential high-severity issue is that XGBoost JARs are not being installed for Spark 4.0, which might be an oversight. Additionally, the script uses add-apt-repository without ensuring its provider package software-properties-common is installed, which will cause script failures. I've also pointed out some opportunities to improve maintainability by replacing hardcoded values with variables and fixing a minor indentation inconsistency. Addressing these points will enhance the script's robustness and correctness.

nvliyuan and others added 6 commits October 20, 2025 17:03
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@nvliyuan
Copy link
Contributor Author

verified in local:
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant