chore: rely on Network.requestWillBeSent to detect navigation start
#2863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadym-chromium
force-pushed
the
sadym/sadym/refactor-navigation-3
branch
from
71c4d45 to
479ebf9
Compare
sadym-chromium
force-pushed
the
sadym/sadym/refactor-navigation-3
branch
2 times, most recently
from
10c5468 to
2624af9
Compare
sadym-chromium
force-pushed
the
sadym/sadym/refactor-navigation-3
branch
from
e9bd47f to
b7b53db
Compare
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
sadym-chromium
force-pushed
the
sadym/sadym/refactor-navigation-3
branch
from
b7b53db to
4677cef
Compare
sadym-chromium
force-pushed
the
sadym/sadym/refactor-navigation-3
branch
from
4677cef to
10cb689
Compare
|
Closing in favor of #2881 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing Align navigation with the spec.
Implementation of "alternative 3" from go/webdriver:detect-navigation-started.
Additional beforunload hack.
Rely on “Network.requestWillBeSent” CDP event for
browsingContext.navigationStartedevent.