misc(build): report to buildtracker on commit via ghactions #10550
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| # Workflow that only runs when a commit lands on master. | ||
|
|
||
| name: 👷♀️ | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - master | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| buildtracker: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: git clone | ||
| uses: actions/checkout@v2 | ||
|
|
||
| - name: Use Node.js 10.x | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: 10.x | ||
|
|
||
| - run: yarn --frozen-lockfile | ||
| - run: yarn build-all | ||
|
|
||
| - name: Store in buildtracker | ||
| run: yarn bt-cli upload-build | ||
| env: | ||
| # https://buildtracker.dev/docs/guides/github-actions#configuration | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
There was a problem hiding this comment. I think |
||
| BT_API_AUTH_TOKEN: ${{ secrets.BT_API_AUTH_TOKEN }} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| // https://buildtracker.dev/docs/installation/#upload-your-builds | ||
|
|
||
| 'use strict'; | ||
|
|
||
| module.exports = { | ||
| applicationUrl: 'https://lh-build-tracker.herokuapp.com', | ||
| artifacts: [ | ||
| 'dist/lightrider/lighthouse-lr-bundle.js', | ||
| 'dist/extension/scripts/lighthouse-ext-bundle.js', | ||
| 'dist/lighthouse-dt-bundle.js', | ||
| 'dist/viewer/src/viewer.js', | ||
| 'dist/lightrider/report-generator-bundle.js', | ||
| 'dist/dt-report-resources/report.js', | ||
| 'dist/dt-report-resources/report-generator.js', | ||
| ], | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -74,6 +74,7 @@ | |
| "static-server": "node lighthouse-cli/test/fixtures/static-server.js" | ||
| }, | ||
| "devDependencies": { | ||
| "@build-tracker/cli": "^1.0.0-beta.14", | ||
|
There was a problem hiding this comment. theres beta 15 now paularmstrong/build-tracker@v1.0.0-beta.14...v1.0.0-beta.15 There was a problem hiding this comment. good catch. i actually asked him to publish that one. :) |
||
| "@firebase/app-types": "0.3.1", | ||
| "@firebase/auth-types": "0.3.2", | ||
| "@firebase/util": "0.2.1", | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wdyt of just adding this to the basic workflow? You need to install node, run yarn and build for this to work, so it's already a heavy workflow.
#10549 reused basic.yml for the same reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is installing node 10 so heavy? I don't understand how e.g. in https://github.com/GoogleChrome/lighthouse/pull/10549/checks?check_run_id=565300864 protoc, python, and pip run in like 3% of the time node setup does. Obviously protoc is pre-compiled, but what's the lazy node action doing in there?
If it stays at 2.5 minutes I foresee all actions going in this file :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont know.. i see it taking a while today but in previous master commits, that step takes <3s.