fix(#259): wallet badge mobile viewport overlay/clickability - #369
Merged
1 commit merged intoAug 31, 2026
Merged
Conversation
- Add flex-wrap and min-w-0 to nav items container so items wrap instead of overflowing horizontally on narrow viewports (iPhone SE) - Add relative z-10 to <nav> to establish a stacking context above non-overlay page content - Replace inline wallet span + disconnect button with WalletBadge component (adds proper a11y attrs and shrink-0 for mobile) - Tighten nav padding on mobile (px-4 sm:px-6, py-3 sm:py-4) - Remove now-unused short() address helper from Navbar - Add WalletBadge.test.tsx: 18 tests covering interactive element presence, click handler firing, and desktop regression at common mobile viewport heights (375x568, 375x667, 414x736)
Contributor
Author
|
close issue #259 |
godamongstmen897
closed this pull request by merging all changes
into
Goldii-locks:main
in
08e9ec6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #241