Add DisputeRaiseModal — a11y, empty state, interactive states, unit t… - #368
Open
blockchainrafik wants to merge 1 commit into
Open
Add DisputeRaiseModal — a11y, empty state, interactive states, unit t…#368blockchainrafik wants to merge 1 commit into
blockchainrafik wants to merge 1 commit into
Conversation
|
@blockchainrafik Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
DisputeRaiseModal— a11y, empty state, interactive states, unit testsChanges
app/components/DisputeRaiseModal.tsx(new)EmptyStatePlaceholderrendered whenmilestoneIndexisnull— descriptive heading, supporting text,"Waiting for selection"status badgerole="dialog",aria-modal="true",aria-labelledby,aria-describedby,role="alert"on warning banner,aria-live="polite"on empty state,aria-label+aria-disabledon all buttons, Escape key + Tab focus trap + backdrop click to closehover:bg-danger-soft/20,hover:border-danger-soft,active:scale-[0.97],focus-visible:ring-danger-soft/ring-accent-soft,disabled:opacity-40 disabled:cursor-not-allowed)ButtonSpinner+ pending label during in-flight state;TxStatusBannerwired todisputeState__tests__/dispute-raise-modal.test.tsx(new)milestoneLabelhelper, full ARIA attribute compliance, every interactive Tailwind class, callback wiring, isPending behaviour, amount display, TxStatusBanner visibilityCloses #330
Closes #331
Closes #333
Closes #339