feat(loading-skeleton): constrain height and preserve clickability on mobile - #352
Open
otsimaofficial wants to merge 1 commit into
Open
Conversation
… mobile Cap the skeleton's height on small viewports and let it scroll internally (overscroll-contain) instead of pushing surrounding controls off-screen, while keeping the wrapper free of fixed/absolute positioning so it never traps taps on other elements. Closes Goldii-locks#279
|
@otsimaofficial Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem & Goal
On short mobile viewports,
LoadingSkeleton's unconstrained height could push surrounding controls (role filters, pagination) far off-screen while a job's details were loading.Changes
data-testid="loading-skeleton-mobile-wrapper"div:max-h-[70vh] overflow-y-auto overscroll-containon mobile,sm:max-h-noneto lift the cap on larger screens — it scrolls internally instead of growing the page.fixed/absolutepositioning, so it can't trap pointer events on other elements.Testing
__tests__/loading-skeleton-mobile.test.tsx(5 tests): height cap + scroll classes, thesm:max-h-nonebreakpoint,overscroll-contain, no fixed/absolute positioning, and — rendering the realDashboardwith a never-resolving fetch so the skeleton stays visible — that the role-filter buttons remain enabled and clickable while it's shown.npx tsc --noEmit, the new test file, andnpm run buildall pass locally.Note:
npm run lintcurrently fails on this repo'smaindue to a pre-existing, unrelatedreact-hooks/set-state-in-effecterror inSignatureTimeoutAlert.tsx(visible on the last several merged PRs' CI runs). That's fixed independently in a separate PR and isn't touched here.Closes #279
🤖 Generated with Claude Code