feat(dashboard): descriptive empty-state view for the job list - #350
Open
otsimaofficial wants to merge 1 commit into
Open
feat(dashboard): descriptive empty-state view for the job list#350otsimaofficial wants to merge 1 commit into
otsimaofficial wants to merge 1 commit into
Conversation
Replace the bare "No jobs found" line with a reusable EmptyState component (icon, heading, supporting copy) shown once loading finishes with zero jobs for the connected wallet. Closes Goldii-locks#276
|
@otsimaofficial Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem & Goal
The dashboard's job list fell back to a single bare line of gray text ("No jobs found for this wallet") when a wallet had zero jobs — no icon, no guidance on what to do next.
Changes
app/components/EmptyState.tsx(icon + heading + supporting description,animate-fade-inon mount).app/dashboard/page.tsx's zero-jobs branch (the empty counterpart to theLoadingSkeletonshown while that same list is loading), with copy that nudges the user to create a job.Testing
__tests__/empty-state.test.tsx(5 tests) covers the component in isolation (title/description, default vs custom icon, decorative icon hidden from assistive tech, fade-in class).__tests__/dashboard-empty-state.test.tsx(4 tests) covers it wired into the dashboard: renders on zero jobs, shows the right copy, disappears once jobs exist, stays hidden when no wallet is connected.__tests__/dashboard-empty-transition.test.tsxstill passes unchanged.npx tsc --noEmitandnpm run buildpass locally.Note:
npm run lintcurrently fails on this repo'smaindue to a pre-existing, unrelatedreact-hooks/set-state-in-effecterror inSignatureTimeoutAlert.tsx(visible on the last several merged PRs' CI runs). That's fixed independently in a separate PR and isn't touched here.Closes #276
🤖 Generated with Claude Code