feat(loading-skeleton): responsive sizing across mobile/tablet/desktop - #349
Open
otsimaofficial wants to merge 1 commit into
Open
feat(loading-skeleton): responsive sizing across mobile/tablet/desktop#349otsimaofficial wants to merge 1 commit into
otsimaofficial wants to merge 1 commit into
Conversation
Stack the stat grid and content rows to a single column on mobile, two on tablet, three on desktop, and use responsive padding/spacing so LoadingSkeleton scales cleanly at every breakpoint. Closes Goldii-locks#275
|
@otsimaofficial Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem & Goal
LoadingSkeletonused a fixed 1→3 column grid and static padding, so it didn't scale cleanly between mobile, tablet, and desktop viewports.Changes
grid-cols-1on mobile →sm:grid-cols-2on tablet →md:grid-cols-3on desktop.p-4 sm:p-6,space-y-4 sm:space-y-6) and the header stacksflex-col→sm:flex-row.w-full sm:w-*so they don't overflow narrow screens.data-testids (loading-skeleton,loading-skeleton-card,loading-skeleton-stats,loading-skeleton-rows) for test targeting.Testing
__tests__/loading-skeleton-responsive.test.tsx(9 tests) asserts the responsive class breakpoints and that the accessible loading announcement is preserved.npx tsc --noEmit, the new test file, andnpm run buildall pass locally.Note:
npm run lintcurrently fails on this repo'smaindue to a pre-existing, unrelatedreact-hooks/set-state-in-effecterror inSignatureTimeoutAlert.tsx(visible on the last several merged PRs' CI runs). That's fixed independently in a separate PR and isn't touched here.Closes #275
🤖 Generated with Claude Code