Skip to content

Commit

Permalink
Allow more account types in the payment window's transfer account list
Browse files Browse the repository at this point in the history
So far it was limited to Asset, Liability, Credit Card
and either Income (for customer payments) or Expenses (for vendor payments).

There are however use cases where a customer payment also covers
expenses (like for example a Paypal service charge).

To allow for as many edge cases as possible the
filter now only excludes those account types I worry
will break the business logic: AP and AR accounts.
That is, with this change you won't be able to create a
customer payment (which necessarily has one split an an AR account)
that transfers to another AR or to an AP account.

While even that may work, I am sure the business features weren't
designed to cope with this and I can't exhaustively test that.
  • Loading branch information
gjanssens committed Dec 31, 2024
1 parent 8b4347d commit 83b49c3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion gnucash/gnome/dialog-payment.c
Original file line number Diff line number Diff line change
Expand Up @@ -1150,7 +1150,7 @@ gnc_payment_set_account_types (GncTreeViewAccount *tree)
gnc_tree_view_account_get_view_info (tree, &avi);

for (i = 0; i < NUM_ACCOUNT_TYPES; i++)
avi.include_type[i] = gncBusinessIsPaymentAcctType (i);
avi.include_type[i] = !xaccAccountIsAPARType (i);

gnc_tree_view_account_set_view_info (tree, &avi);
}
Expand Down

0 comments on commit 83b49c3

Please sign in to comment.